| Message ID | 1497884657-3744-2-git-send-email-madalin.bucur@nxp.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Madalin, On Mon, Jun 19, 2017 at 5:04 PM, Madalin Bucur <madalin.bucur@nxp.com> wrote: > Make sure dma_ops are set, to be later used by the Ethernet driver. > > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > --- > drivers/net/ethernet/freescale/fman/mac.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c > index 0b31f85..6e67d22f 100644 > --- a/drivers/net/ethernet/freescale/fman/mac.c > +++ b/drivers/net/ethernet/freescale/fman/mac.c > @@ -623,6 +623,8 @@ static struct platform_device *dpaa_eth_add_device(int fman_id, > goto no_mem; > } > > + set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); > + When compile-testing with f NO_DMA=y: drivers/net/ethernet/freescale/fman/mac.c: In function ‘dpaa_eth_add_device’: drivers/net/ethernet/freescale/fman/mac.c:626: error: implicit declaration of function ‘set_dma_ops’ Reverting commit 5567e989198b5a8d fixes this regression in v4.12-rc7. Why is this change needed? There's no single other call to the DMA API in this file? If it's really needed, can't set_dma_ops() be called from the driver that needs it, cfr. your other patch "[PATCH 2/2] dpaa_eth: reuse the dma_ops provided by the FMan MAC device"? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> -----Original Message----- > From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] > On Behalf Of Geert Uytterhoeven > Sent: Monday, June 26, 2017 10:49 AM > To: Madalin-cristian Bucur <madalin.bucur@nxp.com> > Cc: netdev@vger.kernel.org; David S. Miller <davem@davemloft.net>; > linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] fsl/fman: propagate dma_ops > > Hi Madalin, > > On Mon, Jun 19, 2017 at 5:04 PM, Madalin Bucur <madalin.bucur@nxp.com> > wrote: > > Make sure dma_ops are set, to be later used by the Ethernet driver. > > > > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > > --- > > drivers/net/ethernet/freescale/fman/mac.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/ethernet/freescale/fman/mac.c > b/drivers/net/ethernet/freescale/fman/mac.c > > index 0b31f85..6e67d22f 100644 > > --- a/drivers/net/ethernet/freescale/fman/mac.c > > +++ b/drivers/net/ethernet/freescale/fman/mac.c > > @@ -623,6 +623,8 @@ static struct platform_device > *dpaa_eth_add_device(int fman_id, > > goto no_mem; > > } > > > > + set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); > > + > > When compile-testing with f NO_DMA=y: > > drivers/net/ethernet/freescale/fman/mac.c: In function > ‘dpaa_eth_add_device’: > drivers/net/ethernet/freescale/fman/mac.c:626: error: implicit > declaration of function ‘set_dma_ops’ > > Reverting commit 5567e989198b5a8d fixes this regression in v4.12-rc7. > > Why is this change needed? > There's no single other call to the DMA API in this file? We're setting here the dma_ops that are later used in the other driver/patch. The problem is we now depend upon DMA but do not explicitly declare it: <<Code that depends on the dma-mapping API needs to set 'depends on HAS_DMA' in its Kconfig>> I'll need to add this to the FMan driver Kconfig. > If it's really needed, can't set_dma_ops() be called from the driver that > needs it, cfr. your other patch "[PATCH 2/2] dpaa_eth: reuse the dma_ops > provided by the FMan MAC device"? > > Thanks! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds Thanks, Madalin
Hi Madalin, On Mon, Jun 26, 2017 at 4:55 PM, Madalin-cristian Bucur <madalin.bucur@nxp.com> wrote: >> -----Original Message----- >> From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] >> On Behalf Of Geert Uytterhoeven >> Sent: Monday, June 26, 2017 10:49 AM >> To: Madalin-cristian Bucur <madalin.bucur@nxp.com> >> Cc: netdev@vger.kernel.org; David S. Miller <davem@davemloft.net>; >> linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH 1/2] fsl/fman: propagate dma_ops >> > On Mon, Jun 19, 2017 at 5:04 PM, Madalin Bucur <madalin.bucur@nxp.com> >> wrote: >> > Make sure dma_ops are set, to be later used by the Ethernet driver. >> > >> > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> >> > --- >> > drivers/net/ethernet/freescale/fman/mac.c | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/drivers/net/ethernet/freescale/fman/mac.c >> b/drivers/net/ethernet/freescale/fman/mac.c >> > index 0b31f85..6e67d22f 100644 >> > --- a/drivers/net/ethernet/freescale/fman/mac.c >> > +++ b/drivers/net/ethernet/freescale/fman/mac.c >> > @@ -623,6 +623,8 @@ static struct platform_device >> *dpaa_eth_add_device(int fman_id, >> > goto no_mem; >> > } >> > >> > + set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); >> > + >> >> When compile-testing with f NO_DMA=y: >> >> drivers/net/ethernet/freescale/fman/mac.c: In function >> ‘dpaa_eth_add_device’: >> drivers/net/ethernet/freescale/fman/mac.c:626: error: implicit >> declaration of function ‘set_dma_ops’ >> >> Reverting commit 5567e989198b5a8d fixes this regression in v4.12-rc7. >> >> Why is this change needed? >> There's no single other call to the DMA API in this file? > > We're setting here the dma_ops that are later used in the other driver/patch. > The problem is we now depend upon DMA but do not explicitly declare it: > > <<Code that depends on the dma-mapping API needs to set 'depends on HAS_DMA' > in its Kconfig>> Sure. But only if the driver really uses DMA. I can stick a set_dma_ops() call in whatever driver, but that doesn't mean it will suddenly use DMA. Why does the FMan driver suddenly has a dependency on DMA, if it doesn't use DMA? > I'll need to add this to the FMan driver Kconfig. Why does the FMan driver need this? Why can't his call be done in the driver that uses the DMA APIO? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> -----Original Message----- > From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] > On Behalf Of Geert Uytterhoeven > Sent: Monday, June 26, 2017 7:24 PM > To: Madalin-cristian Bucur <madalin.bucur@nxp.com> > Cc: netdev@vger.kernel.org; David S. Miller <davem@davemloft.net>; > linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] fsl/fman: propagate dma_ops > > Hi Madalin, > > On Mon, Jun 26, 2017 at 4:55 PM, Madalin-cristian Bucur > <madalin.bucur@nxp.com> wrote: > >> -----Original Message----- > >> From: geert.uytterhoeven@gmail.com > [mailto:geert.uytterhoeven@gmail.com] > >> On Behalf Of Geert Uytterhoeven > >> Sent: Monday, June 26, 2017 10:49 AM > >> To: Madalin-cristian Bucur <madalin.bucur@nxp.com> > >> Cc: netdev@vger.kernel.org; David S. Miller <davem@davemloft.net>; > >> linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org > >> Subject: Re: [PATCH 1/2] fsl/fman: propagate dma_ops > >> > > On Mon, Jun 19, 2017 at 5:04 PM, Madalin Bucur <madalin.bucur@nxp.com> > >> wrote: > >> > Make sure dma_ops are set, to be later used by the Ethernet driver. > >> > > >> > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > >> > --- > >> > drivers/net/ethernet/freescale/fman/mac.c | 2 ++ > >> > 1 file changed, 2 insertions(+) > >> > > >> > diff --git a/drivers/net/ethernet/freescale/fman/mac.c > >> b/drivers/net/ethernet/freescale/fman/mac.c > >> > index 0b31f85..6e67d22f 100644 > >> > --- a/drivers/net/ethernet/freescale/fman/mac.c > >> > +++ b/drivers/net/ethernet/freescale/fman/mac.c > >> > @@ -623,6 +623,8 @@ static struct platform_device > >> *dpaa_eth_add_device(int fman_id, > >> > goto no_mem; > >> > } > >> > > >> > + set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); > >> > + > >> > >> When compile-testing with f NO_DMA=y: > >> > >> drivers/net/ethernet/freescale/fman/mac.c: In function > >> ‘dpaa_eth_add_device’: > >> drivers/net/ethernet/freescale/fman/mac.c:626: error: implicit > >> declaration of function ‘set_dma_ops’ > >> > >> Reverting commit 5567e989198b5a8d fixes this regression in v4.12-rc7. > >> > >> Why is this change needed? > >> There's no single other call to the DMA API in this file? > > > > We're setting here the dma_ops that are later used in the other > driver/patch. > > The problem is we now depend upon DMA but do not explicitly declare it: > > > > <<Code that depends on the dma-mapping API needs to set 'depends on > HAS_DMA' > > in its Kconfig>> > > Sure. But only if the driver really uses DMA. > I can stick a set_dma_ops() call in whatever driver, but that doesn't > mean it will > suddenly use DMA. > Why does the FMan driver suddenly has a dependency on DMA, if it doesn't > use DMA? > > > I'll need to add this to the FMan driver Kconfig. > > Why does the FMan driver need this? > Why can't his call be done in the driver that uses the DMA APIO? The DPAA Ethernet driver makes use of DMA ops. It used to get them from an API call (arch_setup_dma_ops) that was not exported. The DPAA Ethernet that makes use of the FMan devices does not get the dma_ops as it does not probe neither as an OF platform device nor thorough ACPI. It probes as a platform device based on information prepared by the FMan driver. What the FMan change [1] does is supplement the information shared with the Ethernet driver with the dma_ops that the FMan driver gets during OF probing. There are no scenarios one can use the DPAA drivers with NO_DMA, as far as I know. For general info on the DPAA drivers please refer to the documentation found in Documentation/networking/dpaa.txt. For the probing of the Ethernet driver see change [2] and dpaa_eth_add_device() in fsl/fman, dpaa_eth_probe() in dpaa_eth. [1] 5567e989198b5a8d fsl/fman: propagate dma_ops [2] fb52728a9294d97d dpaa_eth: reuse the dma_ops provided by the FMan MAC device > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds Thanks, Madalin
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 0b31f85..6e67d22f 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -623,6 +623,8 @@ static struct platform_device *dpaa_eth_add_device(int fman_id, goto no_mem; } + set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); + ret = platform_device_add_data(pdev, &data, sizeof(data)); if (ret) goto err;
Make sure dma_ops are set, to be later used by the Ethernet driver. Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- drivers/net/ethernet/freescale/fman/mac.c | 2 ++ 1 file changed, 2 insertions(+)