| Message ID | 1497857252-8308-3-git-send-email-jteki@openedev.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Mon, 19 Jun 2017 12:57:28 +0530, Jagan Teki wrote: > From: Jagan Teki <jagan@amarulasolutions.com> > > Since the board have support for nand, better to explicitly > name it with mmc. > > engicam_imx6qdl_icore_defconfig => engicam_imx6qdl_icore_mmc_defconfig > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> Unless we are going to introduce other configurations for the same board (to support NAND booting), then I would prefer to keep the name without the "mmc". The readme.txt can explain that the configuration supports MMC booting. Also, in the follow-up patches, please avoid the _mmc_ part in the defconfig name. Thanks, Thomas
On Tue, Jun 20, 2017 at 1:49 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Mon, 19 Jun 2017 12:57:28 +0530, Jagan Teki wrote: >> From: Jagan Teki <jagan@amarulasolutions.com> >> >> Since the board have support for nand, better to explicitly >> name it with mmc. >> >> engicam_imx6qdl_icore_defconfig => engicam_imx6qdl_icore_mmc_defconfig >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > Unless we are going to introduce other configurations for the same > board (to support NAND booting), then I would prefer to keep the name > without the "mmc". The readme.txt can explain that the configuration > supports MMC booting. I see a point where these defconfig names is in-line with U-Boot defconfig - since like U-Boot have defconfig based on boot-modes buildroot have similar approach. thanks!
Hello, On Tue, 20 Jun 2017 08:00:04 +0530, Jagan Teki wrote: > > Unless we are going to introduce other configurations for the same > > board (to support NAND booting), then I would prefer to keep the name > > without the "mmc". The readme.txt can explain that the configuration > > supports MMC booting. > > I see a point where these defconfig names is in-line with U-Boot > defconfig - since like U-Boot have defconfig based on boot-modes > buildroot have similar approach. There is no special reason to have the Buildroot defconfig name match 1:1 the U-Boot name, so please drop the _mmc_ part of the Buildroot defconfig names. Thanks! Thomas
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 36ef1d1..c4bf90d 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -89,7 +89,7 @@ ci20_defconfig: *defconfig ci40_defconfig: *defconfig csky_gx6605s_defconfig: *defconfig cubieboard2_defconfig: *defconfig -engicam_imx6qdl_icore_defconfig: *defconfig +engicam_imx6qdl_icore_mmc_defconfig: *defconfig firefly_rk3288_defconfig: *defconfig firefly_rk3288_demo_defconfig: *defconfig freescale_imx28evk_defconfig: *defconfig diff --git a/DEVELOPERS b/DEVELOPERS index 9a8b586..85d81dc 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -837,7 +837,7 @@ F: package/keepalived/ N: Jagan Teki <jagan@amarulasolutions.com> F: board/engicam/ -F: configs/engicam_imx6qdl_icore_defconfig +F: configs/engicam_imx6qdl_icore_mmc_defconfig N: James Knight <james.knight@rockwellcollins.com> F: package/atkmm/ diff --git a/board/engicam/readme.txt b/board/engicam/readme.txt index d02c3af..0ef108d 100644 --- a/board/engicam/readme.txt +++ b/board/engicam/readme.txt @@ -17,7 +17,7 @@ First, configure Buildroot for the Engicam i.MX SOM's: - for i.CoreM6 Quad/Dual: - make engicam_imx6qdl_icore_defconfig + make engicam_imx6qdl_icore_mmc_defconfig Build all components: diff --git a/configs/engicam_imx6qdl_icore_defconfig b/configs/engicam_imx6qdl_icore_mmc_defconfig similarity index 100% rename from configs/engicam_imx6qdl_icore_defconfig rename to configs/engicam_imx6qdl_icore_mmc_defconfig