From patchwork Thu Jan 6 14:14:39 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 77718 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A0A1DB70A9 for ; Fri, 7 Jan 2011 01:23:27 +1100 (EST) Received: from localhost ([127.0.0.1]:39878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Paqjz-000609-6n for incoming@patchwork.ozlabs.org; Thu, 06 Jan 2011 09:22:59 -0500 Received: from [140.186.70.92] (port=47552 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Paqc7-0002Hl-96 for qemu-devel@nongnu.org; Thu, 06 Jan 2011 09:14:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Paqc1-0000ca-4r for qemu-devel@nongnu.org; Thu, 06 Jan 2011 09:14:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Paqc0-0000cC-Tc for qemu-devel@nongnu.org; Thu, 06 Jan 2011 09:14:45 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p06EEiN1019287 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Jan 2011 09:14:44 -0500 Received: from rincewind.home.kraxel.org (vpn1-4-139.ams2.redhat.com [10.36.4.139]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p06EEgDj014496; Thu, 6 Jan 2011 09:14:42 -0500 Received: by rincewind.home.kraxel.org (Postfix, from userid 500) id 6B096415AA; Thu, 6 Jan 2011 15:14:41 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Thu, 6 Jan 2011 15:14:39 +0100 Message-Id: <1294323280-21692-4-git-send-email-kraxel@redhat.com> In-Reply-To: <1294323280-21692-1-git-send-email-kraxel@redhat.com> References: <1294323280-21692-1-git-send-email-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Gerd Hoffmann Subject: [Qemu-devel] [PATCH v2 3/4] vga: tag as not hotplugable. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch tags all vga cards as not hotpluggable. The qemu standard vga will never ever be hotpluggable. For cirrus + vmware it might be possible to get that work some day. Todays we can't handle that for a number of reasons though. Signed-off-by: Gerd Hoffmann --- hw/cirrus_vga.c | 1 + hw/vga-pci.c | 1 + hw/vmware_vga.c | 1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 4f5040c..0d522a0 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -3227,6 +3227,7 @@ static PCIDeviceInfo cirrus_vga_info = { .qdev.desc = "Cirrus CLGD 54xx VGA", .qdev.size = sizeof(PCICirrusVGAState), .qdev.vmsd = &vmstate_pci_cirrus_vga, + .no_hotplug = 1, .init = pci_cirrus_vga_initfn, .romfile = VGABIOS_CIRRUS_FILENAME, .config_write = pci_cirrus_write_config, diff --git a/hw/vga-pci.c b/hw/vga-pci.c index 791ca22..ce9ec45 100644 --- a/hw/vga-pci.c +++ b/hw/vga-pci.c @@ -110,6 +110,7 @@ static PCIDeviceInfo vga_info = { .qdev.name = "VGA", .qdev.size = sizeof(PCIVGAState), .qdev.vmsd = &vmstate_vga_pci, + .no_hotplug = 1, .init = pci_vga_initfn, .config_write = pci_vga_write_config, .romfile = "vgabios-stdvga.bin", diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index d9dd52f..6c59053 100644 --- a/hw/vmware_vga.c +++ b/hw/vmware_vga.c @@ -1318,6 +1318,7 @@ static PCIDeviceInfo vmsvga_info = { .qdev.name = "vmware-svga", .qdev.size = sizeof(struct pci_vmsvga_state_s), .qdev.vmsd = &vmstate_vmware_vga, + .no_hotplug = 1, .init = pci_vmsvga_initfn, .romfile = "vgabios-vmware.bin", };