From patchwork Thu Jan 6 12:19:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerald Pfeifer X-Patchwork-Id: 77706 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 2DBBFB6F1E for ; Thu, 6 Jan 2011 23:19:46 +1100 (EST) Received: (qmail 13416 invoked by alias); 6 Jan 2011 12:19:43 -0000 Received: (qmail 13400 invoked by uid 22791); 6 Jan 2011 12:19:41 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,TW_SV X-Spam-Check-By: sourceware.org Received: from vexpert.dbai.tuwien.ac.at (HELO vexpert.dbai.tuwien.ac.at) (128.131.111.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Jan 2011 12:19:32 +0000 Received: from acrux.dbai.tuwien.ac.at (acrux.dbai.tuwien.ac.at [128.131.111.60]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTPS id 39D4B1E049; Thu, 6 Jan 2011 13:19:28 +0100 (CET) Date: Thu, 6 Jan 2011 13:19:31 +0100 (CET) From: Gerald Pfeifer To: Seongbae Park cc: Diego Novillo , Tom Tromey , gcc-patches , neil@daikokuya.co.uk Subject: Re: [PATCH] new driver level option -wrapper for developer convenience. In-Reply-To: Message-ID: References: <4818859C.40409@google.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Given how long ago this was, I cooked up a patch. Anyone wants to review/comment? On Wed, 30 Apr 2008, Seongbae Park wrote: > 2008-04-30 Seongbae Park > > * gcc.c (wrapper_string): New variable. > (insert_wrapper): New function. > (execute): New option -wrapper. > * doc/invoke.texi (Overall Options): New driver option -wrapper. > > And the previous attachment didn't include invoke.texi change (which was > included in the previous two attachments). I've committed the patch > (attached) as svn revision 134832. Index: gcc/doc/invoke.texi =================================================================== +@item -wrapper +@opindex wrapper +Invoke all subcommands under a wrapper program. It takes a single +comma separated list as an argument, which will be used to invoke +the wrapper: How about making this "This option takes..."? +@smallexample +gcc -c t.c -wrapper gdb,--args +@end smallexample + +This will invoke all subprograms of gcc under "gdb --args", +thus cc1 invocation will be "gdb --args cc1 ...". I believe we should use @samp{gdb --args} and @samp{gdb --args cc1 @dots{}} in these two cases, and possibly "the invocation of @command{cc1}", but in any case @command{cc1}. Gerald 2011-01-06 Gerald Pfeifer * doc/invoke.texi (Overall Options): Improve wording and markup of the description of -wrapper. Index: doc/invoke.texi =================================================================== --- doc/invoke.texi (revision 168442) +++ doc/invoke.texi (working copy) @@ -1360,16 +1360,17 @@ @item -wrapper @opindex wrapper -Invoke all subcommands under a wrapper program. It takes a single -comma separated list as an argument, which will be used to invoke -the wrapper: +Invoke all subcommands under a wrapper program. The name of the +wrapper program and its parameters are passed as a comma separated +list. @smallexample gcc -c t.c -wrapper gdb,--args @end smallexample -This will invoke all subprograms of gcc under "gdb --args", -thus cc1 invocation will be "gdb --args cc1 ...". +This will invoke all subprograms of @command{gcc} under +@samp{gdb --args}, thus the invocation of @command{cc1} will be +@samp{gdb --args cc1 @dots{}}. @item -fplugin=@var{name}.so Load the plugin code in file @var{name}.so, assumed to be a