Patchwork new driver level option -wrapper for developer convenience.

login
register
mail settings
Submitter Gerald Pfeifer
Date Jan. 6, 2011, 12:19 p.m.
Message ID <alpine.LSU.1.10.0805031301460.6827@acrux.dbai.tuwien.ac.at>
Download mbox | patch
Permalink /patch/77706/
State New
Headers show

Comments

Gerald Pfeifer - Jan. 6, 2011, 12:19 p.m.
Given how long ago this was, I cooked up a patch.  Anyone wants to
review/comment?

On Wed, 30 Apr 2008, Seongbae Park wrote:
> 2008-04-30  Seongbae Park  <seongbae.park@gmail.com>
> 
>         * gcc.c (wrapper_string): New variable.
>         (insert_wrapper): New function.
>         (execute): New option -wrapper.
>         * doc/invoke.texi (Overall Options): New driver option -wrapper.
> 
> And the previous attachment didn't include invoke.texi change (which was 
> included in the previous two attachments). I've committed the patch 
> (attached) as svn revision 134832.
Diego Novillo - Jan. 6, 2011, 6:57 p.m.
On Thu, Jan 6, 2011 at 07:19, Gerald Pfeifer <gerald@pfeifer.com> wrote:

> 2011-01-06  Gerald Pfeifer  <gerald@pfeifer.com>
>
>        * doc/invoke.texi (Overall Options): Improve wording and markup
>        of the description of -wrapper.

OK.


Diego.

Patch

Index: gcc/doc/invoke.texi
===================================================================
+@item -wrapper
+@opindex wrapper
+Invoke all subcommands under a wrapper program. It takes a single
+comma separated list as an argument, which will be used to invoke
+the wrapper:

How about making this "This option takes..."?

+@smallexample
+gcc -c t.c -wrapper gdb,--args
+@end smallexample
+
+This will invoke all subprograms of gcc under "gdb --args",
+thus cc1 invocation will be "gdb --args cc1 ...".

I believe we should use @samp{gdb --args} and
@samp{gdb --args cc1 @dots{}} in these two cases, and possibly
"the invocation of @command{cc1}", but in any case @command{cc1}.

Gerald


2011-01-06  Gerald Pfeifer  <gerald@pfeifer.com>

	* doc/invoke.texi (Overall Options): Improve wording and markup
	of the description of -wrapper.

Index: doc/invoke.texi
===================================================================
--- doc/invoke.texi	(revision 168442)
+++ doc/invoke.texi	(working copy)
@@ -1360,16 +1360,17 @@ 
 
 @item -wrapper
 @opindex wrapper
-Invoke all subcommands under a wrapper program. It takes a single
-comma separated list as an argument, which will be used to invoke
-the wrapper:
+Invoke all subcommands under a wrapper program.  The name of the
+wrapper program and its parameters are passed as a comma separated
+list.
 
 @smallexample
 gcc -c t.c -wrapper gdb,--args
 @end smallexample
 
-This will invoke all subprograms of gcc under "gdb --args",
-thus cc1 invocation will be "gdb --args cc1 ...".
+This will invoke all subprograms of @command{gcc} under
+@samp{gdb --args}, thus the invocation of @command{cc1} will be
+@samp{gdb --args cc1 @dots{}}.
 
 @item -fplugin=@var{name}.so
 Load the plugin code in file @var{name}.so, assumed to be a