From patchwork Fri Jun 16 12:10:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serhey Popovych X-Patchwork-Id: 776698 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wpzhs0Tpkz9s8J for ; Fri, 16 Jun 2017 22:10:21 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SmEhy5N7"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752764AbdFPMKT (ORCPT ); Fri, 16 Jun 2017 08:10:19 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34983 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752619AbdFPMKS (ORCPT ); Fri, 16 Jun 2017 08:10:18 -0400 Received: by mail-lf0-f68.google.com with SMTP id v20so3986455lfa.2 for ; Fri, 16 Jun 2017 05:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=SaFQ9v0TosTdd7Z3rlBby1Q8fXztkQzKj98oHPDYHYs=; b=SmEhy5N7ijD2SzRTTxNK0hf+ZoQ+z7rpDgqvHpXSJ7+d4Lgzw6z6MdO6lEGeRsbviQ DQBdLp+H+jRxd6rmaQvpBEGyEMIUNOz5wcwHL/NQjH3MlyLtHPMZZT8PEBtFT65Kbo9X /S6l5Vf/mL+Fl5iCuF+UhSmBjShwsSLTzDoeBCqvHoWAJNykr8fZAcR6lmvbQUB3oSj3 /fTKPqHzZvUDDV22KCXZm/Ehf0s37sg8uQDBdTOluO7dmFBf8RlzqhRIu+f42Y4oNVj8 wHPH5j5ZtRSSZqWWRtSi+qzqwYlAJxHiuZkwX5FBFfkf72/hLPX9HJAXN+sCWcEHAnxX aBfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=SaFQ9v0TosTdd7Z3rlBby1Q8fXztkQzKj98oHPDYHYs=; b=BobSoxB1fr2JFqVqcNh1d+x4UsRHFtmJfAtkup29NDFCuOPIFlI/g4HLzv5w5TH42C zWt9aZAqEsxkJj2UMgwHDnxkF4sJsV7q8gQFn7TDjXq6AHugPWu9Whztf71l75ia/0lZ EeZVlYLPuC9Tq8r4WlZ44Fl9trB2U8zLf8+NEIAy50eDu8yWvCNnW/RBEZP7t2+YHZr/ p7i7ULql9oZSnlNecwcu1EkUjbC6RenZZMnPQ1k9qxv8jx6f+BUvN1blbO6JFT3vu1OF lDgyngqwM9hc+KYtWs/WTyX3RN5Qk4n3aXIch2JmFNjhN5DXm0UOdajxRk5cKMgUBCn7 wxyg== X-Gm-Message-State: AKS2vOw+TgQtslUHWaApQans8nkW381NY34pE9A7ZkCFdjSOVnxIu2pI lR8YGqotFP+3vw1goTTNEw== X-Received: by 10.46.15.2 with SMTP id 2mr3243868ljp.21.1497615016332; Fri, 16 Jun 2017 05:10:16 -0700 (PDT) Received: from tuxracer.synapse.com ([195.238.92.77]) by smtp.gmail.com with ESMTPSA id j19sm554008lfk.67.2017.06.16.05.10.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jun 2017 05:10:15 -0700 (PDT) From: Serhey Popovych To: netdev@vger.kernel.org Subject: [PATCH] loopback: Force LOOPBACK_IFINDEX for registration Date: Fri, 16 Jun 2017 15:10:03 +0300 Message-Id: <1497615003-24762-1-git-send-email-serhe.popovych@gmail.com> X-Mailer: git-send-email 1.8.3.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Now with commit 9c7dafb (net: Allow to create links with given ifindex) support registration of network devices with specific ifindex is added. We can force loopback network device index before call to register_netdev() to ensure we always configure it with LOOPBACK_IFINDEX. Kill BUG_ON() since system can continue without network namespace failed in loopback init path, unless it is init_net namespace where we panic() anyway. Signed-off-by: Serhey Popovych --- drivers/net/loopback.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c index 3061249..d7233aa 100644 --- a/drivers/net/loopback.c +++ b/drivers/net/loopback.c @@ -210,12 +210,13 @@ static __net_init int loopback_net_init(struct net *net) if (!dev) goto out; + dev->ifindex = LOOPBACK_IFINDEX; + dev_net_set(dev, net); err = register_netdev(dev); if (err) goto out_free_netdev; - BUG_ON(dev->ifindex != LOOPBACK_IFINDEX); net->loopback_dev = dev; return 0;