| Message ID | dd1977ad60634797aeb04d3785bafffa0ec53026.1497613944.git.arvind.yadav.cs@gmail.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On Fri, Jun 16, 2017 at 05:24:41PM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by <linux/of.h> work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 465 696 4 1165 48d drivers/ata/pata_octeon_cf.o > > File size after constify octeon_cf_match. > text data bss dec hex filename > 865 280 4 1149 47d drivers/ata/pata_octeon_cf.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied to libata/for-4.13. Thanks.
diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c index f524a90..1ba03d6 100644 --- a/drivers/ata/pata_octeon_cf.c +++ b/drivers/ata/pata_octeon_cf.c @@ -1038,7 +1038,7 @@ static void octeon_cf_shutdown(struct device *dev) } } -static struct of_device_id octeon_cf_match[] = { +static const struct of_device_id octeon_cf_match[] = { { .compatible = "cavium,ebt3000-compact-flash", },
of_device_ids are not supposed to change at runtime. All functions working with of_device_ids provided by <linux/of.h> work with const of_device_ids. So mark the non-const structs as const. File size before: text data bss dec hex filename 465 696 4 1165 48d drivers/ata/pata_octeon_cf.o File size after constify octeon_cf_match. text data bss dec hex filename 865 280 4 1149 47d drivers/ata/pata_octeon_cf.o Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/ata/pata_octeon_cf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)