| Message ID | 20170615195621.GA5600@embeddedgus |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com> Date: Thu, 15 Jun 2017 14:56:21 -0500 > Value assigned to variable _data32_ at lines 1254 and 1257 is > overwritten at line 1260 before it can be used. This makes > such variable assignments useless. > > Addresses-Coverity-ID: 1227049 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Applied, thanks.
Hi David, Quoting David Miller <davem@davemloft.net>: > From: "Gustavo A. R. Silva" <garsilva@embeddedor.com> > Date: Thu, 15 Jun 2017 14:56:21 -0500 > >> Value assigned to variable _data32_ at lines 1254 and 1257 is >> overwritten at line 1260 before it can be used. This makes >> such variable assignments useless. >> >> Addresses-Coverity-ID: 1227049 >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > > Applied, thanks. Absolutely, glad to help. Regards -- Gustavo A. R. Silva
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c index 5ad037c..9115b29 100644 --- a/drivers/atm/solos-pci.c +++ b/drivers/atm/solos-pci.c @@ -1251,10 +1251,10 @@ static int fpga_probe(struct pci_dev *dev, const struct pci_device_id *id) if (reset) { iowrite32(1, card->config_regs + FPGA_MODE); - data32 = ioread32(card->config_regs + FPGA_MODE); + ioread32(card->config_regs + FPGA_MODE); iowrite32(0, card->config_regs + FPGA_MODE); - data32 = ioread32(card->config_regs + FPGA_MODE); + ioread32(card->config_regs + FPGA_MODE); } data32 = ioread32(card->config_regs + FPGA_VER);
Value assigned to variable _data32_ at lines 1254 and 1257 is overwritten at line 1260 before it can be used. This makes such variable assignments useless. Addresses-Coverity-ID: 1227049 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/atm/solos-pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)