Patchwork [Maverick,ti-omap4,SRU] UBUNTU: [Config] enabling CONFIG_TASK_ options for iotop to work

login
register
mail settings
Submitter Ricardo Salveti de Araujo
Date Jan. 4, 2011, 10:10 p.m.
Message ID <1294179002-19038-1-git-send-email-ricardo.salveti@canonical.com>
Download mbox | patch
Permalink /patch/77595/
State Accepted
Delegated to: Tim Gardner
Headers show

Comments

Ricardo Salveti de Araujo - Jan. 4, 2011, 10:10 p.m.
SRU Justification:

Impact: With linux-image-omap4 kernel the user is unable to use tools
like 'iotop', as some important config options are missing for it to work.

Fix: It requires kernel support for CONFIG_TASK_DELAY_ACCT,
CONFIG_TASK_IO_ACCOUNTING and CONFIG_TASK_XACCT. All these config settings
are already enabled by default at the master branch (e.g. omap 3), but are
missing at the ti-omap4 one.

Testcase: With these config options enabled the user is able to open 'iotop'
and see what process is consuming more I/O from his system.

BugLink: http://launchpad.net/bugs/694461

CONFIG_TASK_DELAY_ACCT, CONFIG_TASK_IO_ACCOUNTING and CONFIG_TASK_XACCT
are needed for iotop to work. All these options are already enabled at
the master branch, but were missing at the ti-omap4 one.

Signed-off-by: Ricardo Salveti de Araujo <ricardo.salveti@canonical.com>
---
 debian.ti-omap4/config/config.common.ubuntu |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Stefan Bader - Jan. 5, 2011, 1:34 p.m.
On 01/04/2011 11:10 PM, Ricardo Salveti de Araujo wrote:
> SRU Justification:
> 
> Impact: With linux-image-omap4 kernel the user is unable to use tools
> like 'iotop', as some important config options are missing for it to work.
> 
> Fix: It requires kernel support for CONFIG_TASK_DELAY_ACCT,
> CONFIG_TASK_IO_ACCOUNTING and CONFIG_TASK_XACCT. All these config settings
> are already enabled by default at the master branch (e.g. omap 3), but are
> missing at the ti-omap4 one.
> 
> Testcase: With these config options enabled the user is able to open 'iotop'
> and see what process is consuming more I/O from his system.
> 
> BugLink: http://launchpad.net/bugs/694461
> 
> CONFIG_TASK_DELAY_ACCT, CONFIG_TASK_IO_ACCOUNTING and CONFIG_TASK_XACCT
> are needed for iotop to work. All these options are already enabled at
> the master branch, but were missing at the ti-omap4 one.
> 
> Signed-off-by: Ricardo Salveti de Araujo <ricardo.salveti@canonical.com>
> ---
>  debian.ti-omap4/config/config.common.ubuntu |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
> index b469f32..d797272 100644
> --- a/debian.ti-omap4/config/config.common.ubuntu
> +++ b/debian.ti-omap4/config/config.common.ubuntu
> @@ -2531,8 +2531,9 @@ CONFIG_TABLET_USB_GTCO=m
>  CONFIG_TABLET_USB_KBTAB=m
>  CONFIG_TABLET_USB_WACOM=m
>  CONFIG_TASKSTATS=y
> -# CONFIG_TASK_DELAY_ACCT is not set
> -# CONFIG_TASK_XACCT is not set
> +CONFIG_TASK_DELAY_ACCT=y
> +CONFIG_TASK_IO_ACCOUNTING=y
> +CONFIG_TASK_XACCT=y
>  # CONFIG_TCG_TPM is not set
>  CONFIG_TCP_CONG_ADVANCED=y
>  CONFIG_TCP_CONG_BIC=m

A config change on a topic branch that brings those options into sync with
master sounds fine with me.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Tim Gardner - Jan. 5, 2011, 2:21 p.m.
On 01/04/2011 03:10 PM, Ricardo Salveti de Araujo wrote:
> SRU Justification:
>
> Impact: With linux-image-omap4 kernel the user is unable to use tools
> like 'iotop', as some important config options are missing for it to work.
>
> Fix: It requires kernel support for CONFIG_TASK_DELAY_ACCT,
> CONFIG_TASK_IO_ACCOUNTING and CONFIG_TASK_XACCT. All these config settings
> are already enabled by default at the master branch (e.g. omap 3), but are
> missing at the ti-omap4 one.
>
> Testcase: With these config options enabled the user is able to open 'iotop'
> and see what process is consuming more I/O from his system.
>
> BugLink: http://launchpad.net/bugs/694461
>
> CONFIG_TASK_DELAY_ACCT, CONFIG_TASK_IO_ACCOUNTING and CONFIG_TASK_XACCT
> are needed for iotop to work. All these options are already enabled at
> the master branch, but were missing at the ti-omap4 one.
>
> Signed-off-by: Ricardo Salveti de Araujo<ricardo.salveti@canonical.com>
> ---
>   debian.ti-omap4/config/config.common.ubuntu |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
> index b469f32..d797272 100644
> --- a/debian.ti-omap4/config/config.common.ubuntu
> +++ b/debian.ti-omap4/config/config.common.ubuntu
> @@ -2531,8 +2531,9 @@ CONFIG_TABLET_USB_GTCO=m
>   CONFIG_TABLET_USB_KBTAB=m
>   CONFIG_TABLET_USB_WACOM=m
>   CONFIG_TASKSTATS=y
> -# CONFIG_TASK_DELAY_ACCT is not set
> -# CONFIG_TASK_XACCT is not set
> +CONFIG_TASK_DELAY_ACCT=y
> +CONFIG_TASK_IO_ACCOUNTING=y
> +CONFIG_TASK_XACCT=y
>   # CONFIG_TCG_TPM is not set
>   CONFIG_TCP_CONG_ADVANCED=y
>   CONFIG_TCP_CONG_BIC=m

applied, pushed, and uploaded

Patch

diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
index b469f32..d797272 100644
--- a/debian.ti-omap4/config/config.common.ubuntu
+++ b/debian.ti-omap4/config/config.common.ubuntu
@@ -2531,8 +2531,9 @@  CONFIG_TABLET_USB_GTCO=m
 CONFIG_TABLET_USB_KBTAB=m
 CONFIG_TABLET_USB_WACOM=m
 CONFIG_TASKSTATS=y
-# CONFIG_TASK_DELAY_ACCT is not set
-# CONFIG_TASK_XACCT is not set
+CONFIG_TASK_DELAY_ACCT=y
+CONFIG_TASK_IO_ACCOUNTING=y
+CONFIG_TASK_XACCT=y
 # CONFIG_TCG_TPM is not set
 CONFIG_TCP_CONG_ADVANCED=y
 CONFIG_TCP_CONG_BIC=m