| Message ID | 20170614152124.1076-1-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On 06/14/2017 08:21 AM, Ben Pfaff wrote: > OpenFlow 1.1 and 1.2 support is complete. Simon Horman is not known to > be working on flow entry notifications. > > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > Documentation/topics/openflow.rst | 23 +++-------------------- > 1 file changed, 3 insertions(+), 20 deletions(-) > > diff --git a/Documentation/topics/openflow.rst b/Documentation/topics/openflow.rst > index 00e65411c455..6f71d6c752fc 100644 > --- a/Documentation/topics/openflow.rst > +++ b/Documentation/topics/openflow.rst > @@ -75,28 +75,12 @@ Here are the current approaches in a few tricky areas: > OpenFlow 1.1 > ------------ > > -The list of remaining work items for OpenFlow 1.1 is below. It is probably > -incomplete. > - > -* Match and set double-tagged VLANs (QinQ). > - > - This requires kernel work for reasonable performance. > - > - (optional for OF1.1+) > - > -* VLANs tagged with 88a8 Ethertype. > - > - This requires kernel work for reasonable performance. > - > - (required for OF1.1+) > +OpenFlow 1.1 support is believed to be complete. > > OpenFlow 1.2 > ------------ > > -OpenFlow 1.2 support requires OpenFlow 1.1 as a prerequisite. All the > -additional work specific to Openflow 1.2 are complete. (This is based on the > -change log at the end of the OF1.2 spec. I didn't compare the specs carefully > -yet.) > +OpenFlow 1.2 support is believed to be complete. FWIW it looks fine to me but I am wondering about the passive voice here. Why not just say 'OpenFlow 1.2 support is complete'? Just curious. > > OpenFlow 1.3 > ------------ > @@ -170,8 +154,7 @@ in OVS. > > * Flow entry notifications > > - This seems to be modelled after OVS's NXST_FLOW_MONITOR. (Simon Horman is > - working on this.) > + This seems to be modelled after OVS's NXST_FLOW_MONITOR. LGTM Acked-by: Greg Rose <gvrose8192@gmail.com> > > (EXT-187) > (optional for OF1.4+) >
On Wed, Jun 14, 2017 at 03:24:49PM -0700, Greg Rose wrote: > On 06/14/2017 08:21 AM, Ben Pfaff wrote: > >OpenFlow 1.1 and 1.2 support is complete. Simon Horman is not known to > >be working on flow entry notifications. > > > >Signed-off-by: Ben Pfaff <blp@ovn.org> > >--- > > Documentation/topics/openflow.rst | 23 +++-------------------- > > 1 file changed, 3 insertions(+), 20 deletions(-) > > > >diff --git a/Documentation/topics/openflow.rst b/Documentation/topics/openflow.rst > >index 00e65411c455..6f71d6c752fc 100644 > >--- a/Documentation/topics/openflow.rst > >+++ b/Documentation/topics/openflow.rst > >@@ -75,28 +75,12 @@ Here are the current approaches in a few tricky areas: > > OpenFlow 1.1 > > ------------ > > > >-The list of remaining work items for OpenFlow 1.1 is below. It is probably > >-incomplete. > >- > >-* Match and set double-tagged VLANs (QinQ). > >- > >- This requires kernel work for reasonable performance. > >- > >- (optional for OF1.1+) > >- > >-* VLANs tagged with 88a8 Ethertype. > >- > >- This requires kernel work for reasonable performance. > >- > >- (required for OF1.1+) > >+OpenFlow 1.1 support is believed to be complete. > > > > OpenFlow 1.2 > > ------------ > > > >-OpenFlow 1.2 support requires OpenFlow 1.1 as a prerequisite. All the > >-additional work specific to Openflow 1.2 are complete. (This is based on the > >-change log at the end of the OF1.2 spec. I didn't compare the specs carefully > >-yet.) > >+OpenFlow 1.2 support is believed to be complete. > > FWIW it looks fine to me but I am wondering about the passive voice here. > > Why not just say 'OpenFlow 1.2 support is complete'? Just curious. You're right. This is documentation, not cross-examination. I made that change. > > > > OpenFlow 1.3 > > ------------ > >@@ -170,8 +154,7 @@ in OVS. > > > > * Flow entry notifications > > > >- This seems to be modelled after OVS's NXST_FLOW_MONITOR. (Simon Horman is > >- working on this.) > >+ This seems to be modelled after OVS's NXST_FLOW_MONITOR. > > LGTM > > Acked-by: Greg Rose <gvrose8192@gmail.com> Thanks, I applied this to master.
diff --git a/Documentation/topics/openflow.rst b/Documentation/topics/openflow.rst index 00e65411c455..6f71d6c752fc 100644 --- a/Documentation/topics/openflow.rst +++ b/Documentation/topics/openflow.rst @@ -75,28 +75,12 @@ Here are the current approaches in a few tricky areas: OpenFlow 1.1 ------------ -The list of remaining work items for OpenFlow 1.1 is below. It is probably -incomplete. - -* Match and set double-tagged VLANs (QinQ). - - This requires kernel work for reasonable performance. - - (optional for OF1.1+) - -* VLANs tagged with 88a8 Ethertype. - - This requires kernel work for reasonable performance. - - (required for OF1.1+) +OpenFlow 1.1 support is believed to be complete. OpenFlow 1.2 ------------ -OpenFlow 1.2 support requires OpenFlow 1.1 as a prerequisite. All the -additional work specific to Openflow 1.2 are complete. (This is based on the -change log at the end of the OF1.2 spec. I didn't compare the specs carefully -yet.) +OpenFlow 1.2 support is believed to be complete. OpenFlow 1.3 ------------ @@ -170,8 +154,7 @@ in OVS. * Flow entry notifications - This seems to be modelled after OVS's NXST_FLOW_MONITOR. (Simon Horman is - working on this.) + This seems to be modelled after OVS's NXST_FLOW_MONITOR. (EXT-187) (optional for OF1.4+)
OpenFlow 1.1 and 1.2 support is complete. Simon Horman is not known to be working on flow entry notifications. Signed-off-by: Ben Pfaff <blp@ovn.org> --- Documentation/topics/openflow.rst | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-)