From patchwork Tue Jan 4 22:37:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 77543 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 5CEFCB70F9 for ; Wed, 5 Jan 2011 09:37:42 +1100 (EST) Received: (qmail 5520 invoked by alias); 4 Jan 2011 22:37:40 -0000 Received: (qmail 5436 invoked by uid 22791); 4 Jan 2011 22:37:39 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Jan 2011 22:37:34 +0000 Received: from kpbe17.cbf.corp.google.com (kpbe17.cbf.corp.google.com [172.25.105.81]) by smtp-out.google.com with ESMTP id p04MbVSd026339 for ; Tue, 4 Jan 2011 14:37:31 -0800 Received: from pvg2 (pvg2.prod.google.com [10.241.210.130]) by kpbe17.cbf.corp.google.com with ESMTP id p04MbTFT009615 for ; Tue, 4 Jan 2011 14:37:30 -0800 Received: by pvg2 with SMTP id 2so3823116pvg.2 for ; Tue, 04 Jan 2011 14:37:29 -0800 (PST) Received: by 10.142.13.5 with SMTP id 5mr3265009wfm.403.1294180649708; Tue, 04 Jan 2011 14:37:29 -0800 (PST) Received: from coign.google.com (dhcp-172-22-123-229.mtv.corp.google.com [172.22.123.229]) by mx.google.com with ESMTPS id x18sm31451952wfa.11.2011.01.04.14.37.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 04 Jan 2011 14:37:29 -0800 (PST) From: Ian Lance Taylor To: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: Go patch committed: Don't crash adding multiple value function calls Date: Tue, 04 Jan 2011 14:37:27 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This patch to the Go frontend avoids a crash when doing a binary operation on two function calls which return multiple results. Bootstrapped and tested on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 038b6ab8c6a5 go/types.cc --- a/go/types.cc Tue Jan 04 14:17:55 2011 -0800 +++ b/go/types.cc Tue Jan 04 14:34:43 2011 -0800 @@ -401,6 +401,11 @@ return t1->interface_type()->is_identical(t2->interface_type(), errors_are_identical); + case TYPE_CALL_MULTIPLE_RESULT: + if (reason != NULL) + *reason = "invalid use of multiple value function call"; + return false; + default: gcc_unreachable(); }