| Message ID | 1497372641-3175-1-git-send-email-york.sun@nxp.com |
|---|---|
| State | Accepted |
| Commit | 31417f0e5abacd754e1d576095e76d0e82327ba7 |
| Delegated to: | Tom Rini |
| Headers | show |
On Tue, Jun 13, 2017 at 09:50:41AM -0700, York Sun wrote: > The for loop in cmd_keywords_opt_check() seems to use wrong array to > set boundary, reported by Coverity analysis. > > Signed-off-by: York Sun <york.sun@nxp.com> > CC: Joe Hershberger <joe.hershberger@ni.com> > CC: Tom Rini <trini@konsulko.com> > CC: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> Reported-by: Coverity (CID: 163251) Reviewed-by: Tom Rini <trini@konsulko.com>
On Tue, Jun 13, 2017 at 11:50 AM, York Sun <york.sun@nxp.com> wrote: > The for loop in cmd_keywords_opt_check() seems to use wrong array to > set boundary, reported by Coverity analysis. > > Signed-off-by: York Sun <york.sun@nxp.com> > CC: Joe Hershberger <joe.hershberger@ni.com> > CC: Tom Rini <trini@konsulko.com> > CC: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
On Tue, Jun 13, 2017 at 09:50:41AM -0700, York Sun wrote: > The for loop in cmd_keywords_opt_check() seems to use wrong array to > set boundary, reported by Coverity analysis. > > Signed-off-by: York Sun <york.sun@nxp.com> > CC: Joe Hershberger <joe.hershberger@ni.com> > CC: Tom Rini <trini@konsulko.com> > CC: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> > Reported-by: Coverity (CID: 163251) > Reviewed-by: Tom Rini <trini@konsulko.com> > Acked-by: Joe Hershberger <joe.hershberger@ni.com> Applied to u-boot/master, thanks!
diff --git a/cmd/ethsw.c b/cmd/ethsw.c index 491cb8e..b600965 100644 --- a/cmd/ethsw.c +++ b/cmd/ethsw.c @@ -915,7 +915,7 @@ static void cmd_keywords_opt_check(const struct ethsw_command_def *parsed_cmd, * check if our command's optional keywords match the optional * keywords of an available command */ - for (i = 0; i < ARRAY_SIZE(ethsw_cmd_def); i++) { + for (i = 0; i < ARRAY_SIZE(cmd_opt_def); i++) { keyw_opt_matched = 0; cmd_keyw_p = &parsed_cmd->cmd_to_keywords[keyw_opt_matched]; cmd_keyw_opt_p = &cmd_opt_def[i].cmd_keyword[keyw_opt_matched];
The for loop in cmd_keywords_opt_check() seems to use wrong array to set boundary, reported by Coverity analysis. Signed-off-by: York Sun <york.sun@nxp.com> CC: Joe Hershberger <joe.hershberger@ni.com> CC: Tom Rini <trini@konsulko.com> CC: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> --- cmd/ethsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)