diff mbox

[ovs-dev,V11,03/33] tc: Refactor tcm handle assignment when creating filter qdisc

Message ID 1497366235-20892-4-git-send-email-roid@mellanox.com
State Accepted
Headers show

Commit Message

Roi Dayan June 13, 2017, 3:03 p.m. UTC 
Use the available TC macros instead of 0xffff.

Signed-off-by: Roi Dayan <roid@mellanox.com>
Acked-by: Flavio Leitner <fbl@sysclose.org>
---
 lib/tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman June 14, 2017, 8:26 a.m. UTC | #1 
On Tue, Jun 13, 2017 at 06:03:25PM +0300, Roi Dayan wrote:
> Use the available TC macros instead of 0xffff.
> 
> Signed-off-by: Roi Dayan <roid@mellanox.com>
> Acked-by: Flavio Leitner <fbl@sysclose.org>

Thanks, applied to master.
diff mbox

Patch

diff --git a/lib/tc.c b/lib/tc.c
index d3263a2..a71a9e0 100644
--- a/lib/tc.c
+++ b/lib/tc.c
@@ -95,7 +95,7 @@  tc_add_del_ingress_qdisc(int ifindex, bool add)
     int flags = add ? NLM_F_EXCL | NLM_F_CREATE : 0;
 
     tcmsg = tc_make_request(ifindex, type, flags, &request);
-    tcmsg->tcm_handle = tc_make_handle(0xffff, 0);
+    tcmsg->tcm_handle = TC_H_MAKE(TC_H_INGRESS, 0);
     tcmsg->tcm_parent = TC_H_INGRESS;
     nl_msg_put_string(&request, TCA_KIND, "ingress");
     nl_msg_put_unspec(&request, TCA_OPTIONS, NULL, 0);