| Message ID | 1497192780-7772-1-git-send-email-dn3108@gmail.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Jun 11, 2017 at 11:53:00PM +0900, Minwoo Im wrote: > AHCI 1.3.1 Spec says that software shall build two H2D register > FISes in the command list to send a software reset. > The comments in ahci_do_softreset() is currently D2H instead of H2D. > > Signed-off-by: Minwoo Im <dn3108@gmail.com> Applied to libata/for-4.13. Thanks.
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index 3159f9e..835efe4 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -1400,7 +1400,7 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class, ata_tf_init(link->device, &tf); - /* issue the first D2H Register FIS */ + /* issue the first H2D Register FIS */ msecs = 0; now = jiffies; if (time_after(deadline, now)) @@ -1417,7 +1417,7 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class, /* spec says at least 5us, but be generous and sleep for 1ms */ ata_msleep(ap, 1); - /* issue the second D2H Register FIS */ + /* issue the second H2D Register FIS */ tf.ctl &= ~ATA_SRST; ahci_exec_polled_cmd(ap, pmp, &tf, 0, 0, 0);
AHCI 1.3.1 Spec says that software shall build two H2D register FISes in the command list to send a software reset. The comments in ahci_do_softreset() is currently D2H instead of H2D. Signed-off-by: Minwoo Im <dn3108@gmail.com> --- drivers/ata/libahci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)