From patchwork Tue Jan 4 08:32:23 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 77423 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D8977B70A3 for ; Tue, 4 Jan 2011 19:59:42 +1100 (EST) Received: from localhost ([127.0.0.1]:34598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pa2ge-0005ml-5c for incoming@patchwork.ozlabs.org; Tue, 04 Jan 2011 03:56:12 -0500 Received: from [140.186.70.92] (port=55748 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pa2Jx-00014N-Nv for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:32:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pa2Ju-0004dx-1a for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:32:45 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:37479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pa2Jt-0004dh-RY for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:32:41 -0500 Received: from smtp04.web.de ( [172.20.0.225]) by fmmailgate03.web.de (Postfix) with ESMTP id 3A74418393E3B; Tue, 4 Jan 2011 09:32:41 +0100 (CET) Received: from [88.64.22.98] (helo=localhost.localdomain) by smtp04.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #2) id 1Pa2Jt-00050n-00; Tue, 04 Jan 2011 09:32:41 +0100 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Date: Tue, 4 Jan 2011 09:32:23 +0100 Message-Id: X-Mailer: git-send-email 1.7.1 In-Reply-To: References: In-Reply-To: References: X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1+AP5n4LX0BKsaW+cgSfoBy3pIggB/H8gstWQLr Hvu2xC0TLzCO07v0mWHR5twGKR7HD89enrYUMO7Sxze1ByDiZE NrLV5awk0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: Glauber Costa , qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: [Qemu-devel] [PATCH v3 11/21] kvm: x86: Reset paravirtual MSRs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka Make sure to write the cleared MSR_KVM_SYSTEM_TIME, MSR_KVM_WALL_CLOCK, and MSR_KVM_ASYNC_PF_EN to the kernel state so that a freshly booted guest cannot be disturbed by old values. Signed-off-by: Jan Kiszka CC: Glauber Costa --- target-i386/kvm.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index d8f26bf..8267655 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -845,6 +845,13 @@ static int kvm_put_msrs(CPUState *env, int level) if (smp_cpus == 1 || env->tsc != 0) { kvm_msr_entry_set(&msrs[n++], MSR_IA32_TSC, env->tsc); } + } + /* + * The following paravirtual MSRs have side effects on the guest or are + * too heavy for normal writeback. Limit them to reset or full state + * updates. + */ + if (level >= KVM_PUT_RESET_STATE) { kvm_msr_entry_set(&msrs[n++], MSR_KVM_SYSTEM_TIME, env->system_time_msr); kvm_msr_entry_set(&msrs[n++], MSR_KVM_WALL_CLOCK, env->wall_clock_msr);