| Message ID | 20170610091513.29031-2-bernd.kuhls@t-online.de |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Sat, 10 Jun 2017 11:15:13 +0200, Bernd Kuhls wrote: > + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \ > + !BR2_HOST_GCC_AT_LEAST_4_8 You forgot to add a || here, so this patch causes a clear failure when running "make menuconfig". I've fixed that before pushing of course, but it would be nice if you could at least test your Config.in changes by running "make menuconfig" :) Thanks, Thomas
Am Sat, 10 Jun 2017 23:08:43 +0200 schrieb Thomas Petazzoni: > it would be nice if you could at least test your Config.in changes by > running "make menuconfig" :) Hi, I did but I missed the fact that source "package/qt5/qt5webkit/Config.in" is guarded by if BR2_PACKAGE_QT5 Sorry for the hassle. Regards, Bernd
Hello, On Sun, 11 Jun 2017 08:25:13 +0200, Bernd Kuhls wrote: > > it would be nice if you could at least test your Config.in changes by > > running "make menuconfig" :) > > Hi, > > I did but I missed the fact that > > source "package/qt5/qt5webkit/Config.in" > > is guarded by > > if BR2_PACKAGE_QT5 I didn't had qt5 enabled. All Config.in files are parsed when you run "make menuconfig", even if their inclusion is guarded by a if..endif. Best regards, Thomas
diff --git a/package/qt5/qt5webkit/Config.in b/package/qt5/qt5webkit/Config.in index cef7532e7..a1ff265d4 100644 --- a/package/qt5/qt5webkit/Config.in +++ b/package/qt5/qt5webkit/Config.in @@ -2,6 +2,7 @@ config BR2_PACKAGE_QT5WEBKIT bool "qt5webkit" depends on !BR2_STATIC_LIBS depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE + depends on BR2_HOST_GCC_AT_LEAST_4_8 # icu depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu depends on !BR2_BINFMT_FLAT # icu # assumes a FPU is available on MIPS @@ -27,8 +28,9 @@ config BR2_PACKAGE_QT5WEBKIT http://doc.qt.io/archives/qt-5.5/qtwebkit-index.html -comment "qt5webkit needs a toolchain w/ dynamic library, gcc >= 4.8" - depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 +comment "qt5webkit needs a toolchain w/ dynamic library, gcc >= 4.8, host gcc >= 4.8" + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \ + !BR2_HOST_GCC_AT_LEAST_4_8 depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE depends on !BR2_BINFMT_FLAT depends on !BR2_MIPS_SOFT_FLOAT
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/qt5/qt5webkit/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)