From patchwork Tue Jan 4 08:32:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 77421 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5ACBFB7063 for ; Tue, 4 Jan 2011 19:59:01 +1100 (EST) Received: from localhost ([127.0.0.1]:33925 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pa2jK-0006zV-5g for incoming@patchwork.ozlabs.org; Tue, 04 Jan 2011 03:58:58 -0500 Received: from [140.186.70.92] (port=55752 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pa2Jx-00014Q-Sv for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:32:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pa2Ju-0004e7-Ax for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:32:45 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:56640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pa2Ju-0004dn-4b for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:32:42 -0500 Received: from smtp04.web.de ( [172.20.0.225]) by fmmailgate01.web.de (Postfix) with ESMTP id 8303C184C43FB; Tue, 4 Jan 2011 09:32:41 +0100 (CET) Received: from [88.64.22.98] (helo=localhost.localdomain) by smtp04.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #2) id 1Pa2Jt-00050n-01; Tue, 04 Jan 2011 09:32:41 +0100 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Date: Tue, 4 Jan 2011 09:32:24 +0100 Message-Id: <2c5efab40d7088353c5147c41fb13b44a944679c.1294129949.git.jan.kiszka@web.de> X-Mailer: git-send-email 1.7.1 In-Reply-To: References: In-Reply-To: References: X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1/eNiSUVGuxCxJPmhpugXM7Jf4GCygLHjFUQvao VHaoFSz7tkXBoLrfLa0TfvSwZiufDvR2YBOgakFv+MIN2nsMc8 lu4sjMI5M= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Huang Ying Subject: [Qemu-devel] [PATCH v3 12/21] kvm: x86: Drop MCE MSRs write back restrictions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka There is no need to restrict writing back MCE MSRs to reset or full state updates as setting their values has no side effects. Signed-off-by: Jan Kiszka CC: Huang Ying --- target-i386/kvm.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 8267655..1789bff 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -863,14 +863,10 @@ static int kvm_put_msrs(CPUState *env, int level) if (env->mcg_cap) { int i; - if (level == KVM_PUT_RESET_STATE) { - kvm_msr_entry_set(&msrs[n++], MSR_MCG_STATUS, env->mcg_status); - } else if (level == KVM_PUT_FULL_STATE) { - kvm_msr_entry_set(&msrs[n++], MSR_MCG_STATUS, env->mcg_status); - kvm_msr_entry_set(&msrs[n++], MSR_MCG_CTL, env->mcg_ctl); - for (i = 0; i < (env->mcg_cap & 0xff) * 4; i++) { - kvm_msr_entry_set(&msrs[n++], MSR_MC0_CTL + i, env->mce_banks[i]); - } + kvm_msr_entry_set(&msrs[n++], MSR_MCG_STATUS, env->mcg_status); + kvm_msr_entry_set(&msrs[n++], MSR_MCG_CTL, env->mcg_ctl); + for (i = 0; i < (env->mcg_cap & 0xff) * 4; i++) { + kvm_msr_entry_set(&msrs[n++], MSR_MC0_CTL + i, env->mce_banks[i]); } } #endif