From patchwork Tue Jan 4 08:32:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 77414 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by ozlabs.org (Postfix) with ESMTP id D668AB7063 for ; Tue, 4 Jan 2011 19:51:18 +1100 (EST) Received: from localhost ([127.0.0.1]:44505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pa2Wn-0008JZ-3N for incoming@patchwork.ozlabs.org; Tue, 04 Jan 2011 03:46:01 -0500 Received: from [140.186.70.92] (port=55827 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pa2K2-00016Q-GW for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:32:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pa2Jx-0004fp-8l for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:32:50 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:42649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pa2Jx-0004fW-12 for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:32:45 -0500 Received: from smtp04.web.de ( [172.20.0.225]) by fmmailgate02.web.de (Postfix) with ESMTP id 6A00A192E3DCB; Tue, 4 Jan 2011 09:32:44 +0100 (CET) Received: from [88.64.22.98] (helo=localhost.localdomain) by smtp04.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #2) id 1Pa2Jw-00050n-01; Tue, 04 Jan 2011 09:32:44 +0100 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Date: Tue, 4 Jan 2011 09:32:31 +0100 Message-Id: X-Mailer: git-send-email 1.7.1 In-Reply-To: References: In-Reply-To: References: X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX18iAMTwaPYLXOfPNBABZUFgwrVxmmv1xRD2kM1S a0Psq3EewDapJnebcU0IXxg8EwQPHv9gDxFFSGY2WoyFWCQlRD xvdlNfcnQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: [Qemu-devel] [PATCH v3 19/21] kvm: Flush coalesced mmio buffer on IO window exits X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka We must flush pending mmio writes if we leave kvm_cpu_exec for an IO window. Otherwise we risk to loose those requests when migrating to a different host during that window. Signed-off-by: Jan Kiszka --- kvm-all.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 7a5b299..a5e9246 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -851,6 +851,8 @@ void kvm_cpu_exec(CPUState *env) cpu_single_env = env; kvm_arch_post_run(env, run); + kvm_flush_coalesced_mmio_buffer(); + if (ret == -EINTR || ret == -EAGAIN) { cpu_exit(env); DPRINTF("io window exit\n"); @@ -863,8 +865,6 @@ void kvm_cpu_exec(CPUState *env) abort(); } - kvm_flush_coalesced_mmio_buffer(); - ret = 0; /* exit loop */ switch (run->exit_reason) { case KVM_EXIT_IO: