diff mbox

[trivial] opal-prd: Fix memory leak

Message ID 20170609165318.32171-1-hegdevasant@linux.vnet.ibm.com
State Accepted
Headers show

Commit Message

Vasant Hegde June 9, 2017, 4:53 p.m. UTC 
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 external/opal-prd/i2c.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jeremy Kerr Oct. 16, 2017, 5:55 a.m. UTC | #1 
Hi Vasant,

> --- a/external/opal-prd/i2c.c
> +++ b/external/opal-prd/i2c.c
> @@ -193,6 +193,7 @@ static void i2c_add_bus(uint32_t chip, uint32_t engine, uint32_t port,
>  	if (asprintf(&dn, "/dev/%s", devname) < 0) {
>  		pr_log(LOG_ERR, "I2C: Error creating devpath for %s: %m",
>  			devname);
> +		free(b);
>  		return;
>  	}
>  

Looks good, thanks.

Acked-by: Jeremy Kerr <jk@ozlabs.org>

Cheers,


Jeremy
Stewart Smith Oct. 16, 2017, 8:14 a.m. UTC | #2 
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes:
> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
> ---
>  external/opal-prd/i2c.c | 1 +
>  1 file changed, 1 insertion(+)

(finally) merged to master as of 11cbacf89d1fb19d95526bcdf39be8809789bcf6
diff mbox

Patch

diff --git a/external/opal-prd/i2c.c b/external/opal-prd/i2c.c
index fbe2e9b..ba4b3c8 100644
--- a/external/opal-prd/i2c.c
+++ b/external/opal-prd/i2c.c
@@ -193,6 +193,7 @@  static void i2c_add_bus(uint32_t chip, uint32_t engine, uint32_t port,
 	if (asprintf(&dn, "/dev/%s", devname) < 0) {
 		pr_log(LOG_ERR, "I2C: Error creating devpath for %s: %m",
 			devname);
+		free(b);
 		return;
 	}