| Message ID | 20170609150622.4720-1-f4bug@amsat.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
I intended to send those 3 patches as separate since unrelated, but failed again, sorry :S On 06/09/2017 12:06 PM, Philippe Mathieu-Daudé wrote: > inlined create_unimplemented_device() calls sysbus_mmio_map_overlap(). > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > > v2: Addressed review feedback from Eric Blake > > include/hw/misc/unimp.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h > index 3462d85836..52e068ec3e 100644 > --- a/include/hw/misc/unimp.h > +++ b/include/hw/misc/unimp.h > @@ -8,6 +8,8 @@ > #ifndef HW_MISC_UNIMP_H > #define HW_MISC_UNIMP_H > > +#include "hw/sysbus.h" > + > #define TYPE_UNIMPLEMENTED_DEVICE "unimplemented-device" > > /** >
On 06/09/2017 10:06 AM, Philippe Mathieu-Daudé wrote: > inlined create_unimplemented_device() calls sysbus_mmio_map_overlap(). > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > > v2: Addressed review feedback from Eric Blake > > include/hw/misc/unimp.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h > index 3462d85836..52e068ec3e 100644 > --- a/include/hw/misc/unimp.h > +++ b/include/hw/misc/unimp.h > @@ -8,6 +8,8 @@ > #ifndef HW_MISC_UNIMP_H > #define HW_MISC_UNIMP_H > > +#include "hw/sysbus.h" > + > #define TYPE_UNIMPLEMENTED_DEVICE "unimplemented-device" > > /** >
Applied to -trivial, thanks! /mjt
diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h index 3462d85836..52e068ec3e 100644 --- a/include/hw/misc/unimp.h +++ b/include/hw/misc/unimp.h @@ -8,6 +8,8 @@ #ifndef HW_MISC_UNIMP_H #define HW_MISC_UNIMP_H +#include "hw/sysbus.h" + #define TYPE_UNIMPLEMENTED_DEVICE "unimplemented-device" /**
inlined create_unimplemented_device() calls sysbus_mmio_map_overlap(). Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- v2: Addressed review feedback from Eric Blake include/hw/misc/unimp.h | 2 ++ 1 file changed, 2 insertions(+)