diff mbox

[PULL,05/41] qapi: Clean up qobject_input_type_number() control flow

Message ID 1497016045-6009-6-git-send-email-armbru@redhat.com
State New
Headers show

Commit Message

Markus Armbruster June 9, 2017, 1:46 p.m. UTC 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Use the more common pattern to error out.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20170607163635.17635-6-marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Commit message tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/qobject-input-visitor.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff mbox

Patch

diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c
index eac40f6..26ef49a 100644
--- a/qapi/qobject-input-visitor.c
+++ b/qapi/qobject-input-visitor.c
@@ -547,13 +547,13 @@  static void qobject_input_type_number(Visitor *v, const char *name, double *obj,
     }
 
     qfloat = qobject_to_qfloat(qobj);
-    if (qfloat) {
-        *obj = qfloat_get_double(qobject_to_qfloat(qobj));
+    if (!qfloat) {
+        error_setg(errp, QERR_INVALID_PARAMETER_TYPE,
+                   full_name(qiv, name), "number");
         return;
     }
 
-    error_setg(errp, QERR_INVALID_PARAMETER_TYPE,
-               full_name(qiv, name), "number");
+    *obj = qfloat_get_double(qobject_to_qfloat(qobj));
 }
 
 static void qobject_input_type_number_keyval(Visitor *v, const char *name,