Patchwork [U-Boot] Fix CONFIG_CMD_SHA1SUM

login
register
mail settings
Submitter Alexander Holler
Date Jan. 4, 2011, 7:47 a.m.
Message ID <1294127240-7494-1-git-send-email-holler@ahsoftware.de>
Download mbox | patch
Permalink /patch/77392/
State Accepted
Commit c6b1ee664a12534927fa825346696cbd3ca57774
Headers show

Comments

Alexander Holler - Jan. 4, 2011, 7:47 a.m.
Only CONFIG_CMD_SHA1SUM should have been used.
---
 README           |    2 +-
 common/cmd_mem.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Alexander Holler - Jan. 4, 2011, 8:04 a.m.
Am 04.01.2011 08:47, schrieb Alexander Holler:

> Only CONFIG_CMD_SHA1SUM should have been used.
> ---
>   README           |    2 +-
>   common/cmd_mem.c |    4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
>

Sorry, have forgotten that

Signed-off-by: Alexander Holler <holler@ahsoftware.de>

Regards,

Alexander
Albert ARIBAUD - Jan. 8, 2011, 8:04 a.m.
Le 04/01/2011 09:04, Alexander Holler a écrit :
> Am 04.01.2011 08:47, schrieb Alexander Holler:
>
>> Only CONFIG_CMD_SHA1SUM should have been used.
>> ---
>>    README           |    2 +-
>>    common/cmd_mem.c |    4 ++--
>>    2 files changed, 3 insertions(+), 3 deletions(-)
>>
>
> Sorry, have forgotten that
>
> Signed-off-by: Alexander Holler<holler@ahsoftware.de>
>
> Regards,
>
> Alexander

Hi Alexander,

Maybe a clearer patch subject, such as "Replace CONFIG_CMD_SHA1 with 
CONFIG_CMD_SHA1SUM"? I needed to read the actual changes to see 
CONFIG_CMD_SHA1 mentioned.

Amicalement,

Patch

diff --git a/README b/README
index 68f5fb0..2e70b48 100644
--- a/README
+++ b/README
@@ -675,7 +675,7 @@  The following options need to be configured:
 					  (requires CONFIG_CMD_I2C)
 		CONFIG_CMD_SETGETDCR	  Support for DCR Register access
 					  (4xx only)
-		CONFIG_CMD_SHA1		  print sha1 memory digest
+		CONFIG_CMD_SHA1SUM	  print sha1 memory digest
 					  (requires CONFIG_CMD_MEMORY)
 		CONFIG_CMD_SOURCE	  "source" command Support
 		CONFIG_CMD_SPI		* SPI serial bus support
diff --git a/common/cmd_mem.c b/common/cmd_mem.c
index f7a442a..dae3d01 100644
--- a/common/cmd_mem.c
+++ b/common/cmd_mem.c
@@ -1184,7 +1184,7 @@  int do_md5sum(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 }
 #endif
 
-#ifdef CONFIG_CMD_SHA1
+#ifdef CONFIG_CMD_SHA1SUM
 int do_sha1sum(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	unsigned long addr, len;
@@ -1343,7 +1343,7 @@  U_BOOT_CMD(
 	"compute SHA1 message digest",
 	"address count"
 );
-#endif /* CONFIG_CMD_SHA1 */
+#endif /* CONFIG_CMD_SHA1SUM */
 
 #ifdef CONFIG_CMD_UNZIP
 U_BOOT_CMD(