| Message ID | 20170609103744.3239316-1-arnd@arndb.de |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> When CONFIG_QED_SRIOV is disabled, we get a build error: > > drivers/net/ethernet/qlogic/qed/qed_int.c: In function 'qed_int_sb_init': > drivers/net/ethernet/qlogic/qed/qed_int.c:1499:4: error: implicit declaration > of function 'qed_vf_set_sb_info'; did you mean 'qed_mcp_get_resc_info'? [- > Werror=implicit-function-declaration] > > All the other declarations have a 'static inline' stub as an alternative here, so > this adds one more for qed_int_sb_init. > > Fixes: 50a207147fce ("qed: Hold a single array for SBs") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Missed it. Thanks. Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 9 Jun 2017 12:37:35 +0200 > When CONFIG_QED_SRIOV is disabled, we get a build error: > > drivers/net/ethernet/qlogic/qed/qed_int.c: In function 'qed_int_sb_init': > drivers/net/ethernet/qlogic/qed/qed_int.c:1499:4: error: implicit declaration of function 'qed_vf_set_sb_info'; did you mean 'qed_mcp_get_resc_info'? [-Werror=implicit-function-declaration] > > All the other declarations have a 'static inline' stub as an alternative > here, so this adds one more for qed_int_sb_init. > > Fixes: 50a207147fce ("qed: Hold a single array for SBs") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thank you.
diff --git a/drivers/net/ethernet/qlogic/qed/qed_vf.h b/drivers/net/ethernet/qlogic/qed/qed_vf.h index b65bbc54a097..34d9b882a780 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_vf.h +++ b/drivers/net/ethernet/qlogic/qed/qed_vf.h @@ -1105,6 +1105,11 @@ static inline u16 qed_vf_get_igu_sb_id(struct qed_hwfn *p_hwfn, u16 sb_id) return 0; } +static inline void qed_vf_set_sb_info(struct qed_hwfn *p_hwfn, u16 sb_id, + struct qed_sb_info *p_sb) +{ +} + static inline int qed_vf_pf_vport_start(struct qed_hwfn *p_hwfn, u8 vport_id, u16 mtu,
When CONFIG_QED_SRIOV is disabled, we get a build error: drivers/net/ethernet/qlogic/qed/qed_int.c: In function 'qed_int_sb_init': drivers/net/ethernet/qlogic/qed/qed_int.c:1499:4: error: implicit declaration of function 'qed_vf_set_sb_info'; did you mean 'qed_mcp_get_resc_info'? [-Werror=implicit-function-declaration] All the other declarations have a 'static inline' stub as an alternative here, so this adds one more for qed_int_sb_init. Fixes: 50a207147fce ("qed: Hold a single array for SBs") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/qlogic/qed/qed_vf.h | 5 +++++ 1 file changed, 5 insertions(+)