Patchwork [U-Boot,RFC,12/36] sc520 - Sort Makefile

login
register
mail settings
Submitter Graeme Russ
Date Jan. 3, 2011, 7:46 p.m.
Message ID <1294084016-2674-13-git-send-email-graeme.russ@gmail.com>
Download mbox | patch
Permalink /patch/77319/
State Superseded
Delegated to: Graeme Russ
Headers show

Comments

Graeme Russ - Jan. 3, 2011, 7:46 p.m.
---
 arch/i386/cpu/sc520/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

--
1.7.1.422.g049e9
Wolfgang Denk - Jan. 25, 2011, 8:23 p.m.
Dear Graeme Russ,

In message <1294084016-2674-13-git-send-email-graeme.russ@gmail.com> you wrote:
> ---
>  arch/i386/cpu/sc520/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/i386/cpu/sc520/Makefile b/arch/i386/cpu/sc520/Makefile
> index fb47c20..b962b02 100644
> --- a/arch/i386/cpu/sc520/Makefile
> +++ b/arch/i386/cpu/sc520/Makefile
> @@ -32,9 +32,9 @@ include $(TOPDIR)/config.mk
>  LIB	:= $(obj)lib$(SOC).o
> 
>  COBJS-$(CONFIG_SYS_SC520) += sc520.o
> +COBJS-$(CONFIG_PCI) += sc520_pci.o
>  COBJS-$(CONFIG_SYS_SC520_SSI) += sc520_ssi.o
>  COBJS-$(CONFIG_SYS_SC520_TIMER) += sc520_timer.o
> -COBJS-$(CONFIG_PCI) += sc520_pci.o

Please sort list.

Best regards,

Wolfgang Denk
Graeme Russ - Jan. 26, 2011, 10:28 p.m.
Dear Wolfgang,

On Wed, Jan 26, 2011 at 7:23 AM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Graeme Russ,
>
> In message <1294084016-2674-13-git-send-email-graeme.russ@gmail.com> you wrote:
>> ---
>>  arch/i386/cpu/sc520/Makefile |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/i386/cpu/sc520/Makefile b/arch/i386/cpu/sc520/Makefile
>> index fb47c20..b962b02 100644
>> --- a/arch/i386/cpu/sc520/Makefile
>> +++ b/arch/i386/cpu/sc520/Makefile
>> @@ -32,9 +32,9 @@ include $(TOPDIR)/config.mk
>>  LIB  := $(obj)lib$(SOC).o
>>
>>  COBJS-$(CONFIG_SYS_SC520) += sc520.o
>> +COBJS-$(CONFIG_PCI) += sc520_pci.o
>>  COBJS-$(CONFIG_SYS_SC520_SSI) += sc520_ssi.o
>>  COBJS-$(CONFIG_SYS_SC520_TIMER) += sc520_timer.o
>> -COBJS-$(CONFIG_PCI) += sc520_pci.o
>
> Please sort list.
>

I thought I did by moving sc520_pci between sc520 and sc520_ssi

Or should I sort based on CONFIG_ defines?

Regards,

Graeme
Wolfgang Denk - Jan. 27, 2011, 10:46 a.m.
Dear Graeme Russ,

In message <AANLkTimHwcRECMGjrfbqnW-NaBODn3g0rznfbA2S3mLK@mail.gmail.com> you wrote:
> 
> I thought I did by moving sc520_pci between sc520 and sc520_ssi
> 
> Or should I sort based on CONFIG_ defines?

That's what I expected, but you are probably right.  Please ignore me.
You have my ACK.

Best regards,

Wolfgang Denk

Patch

diff --git a/arch/i386/cpu/sc520/Makefile b/arch/i386/cpu/sc520/Makefile
index fb47c20..b962b02 100644
--- a/arch/i386/cpu/sc520/Makefile
+++ b/arch/i386/cpu/sc520/Makefile
@@ -32,9 +32,9 @@  include $(TOPDIR)/config.mk
 LIB	:= $(obj)lib$(SOC).o

 COBJS-$(CONFIG_SYS_SC520) += sc520.o
+COBJS-$(CONFIG_PCI) += sc520_pci.o
 COBJS-$(CONFIG_SYS_SC520_SSI) += sc520_ssi.o
 COBJS-$(CONFIG_SYS_SC520_TIMER) += sc520_timer.o
-COBJS-$(CONFIG_PCI) += sc520_pci.o

 SOBJS-$(CONFIG_SYS_SC520) += sc520_asm.o