| Message ID | 1496927934-21815-1-git-send-email-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
Thomas Huth <thuth@redhat.com> wrote: > There does not seem to be any target specific code in core.c, so we can > put it into "common-obj" instead of "obj" to compile it only once for > all targets. > > Signed-off-by: Thomas Huth <thuth@redhat.com> It compiles. I can't see anything that is target dependent on core.c. So Reviewed-by: Juan Quintela <quintela@redhat.com>
On Thu, Jun 08, 2017 at 04:23:34PM +0200, Juan Quintela wrote: > Thomas Huth <thuth@redhat.com> wrote: > > There does not seem to be any target specific code in core.c, so we can > > put it into "common-obj" instead of "obj" to compile it only once for > > all targets. > > > > Signed-off-by: Thomas Huth <thuth@redhat.com> > > It compiles. > I can't see anything that is target dependent on core.c. > > So > > Reviewed-by: Juan Quintela <quintela@redhat.com> I've merged this into my ppc-for-2.10 tree, on the basis that ppc is the only user of core.c so far. Any objections?
On Fri, Jun 09, 2017 at 12:03:38PM +1000, David Gibson wrote: > On Thu, Jun 08, 2017 at 04:23:34PM +0200, Juan Quintela wrote: > > Thomas Huth <thuth@redhat.com> wrote: > > > There does not seem to be any target specific code in core.c, so we can > > > put it into "common-obj" instead of "obj" to compile it only once for > > > all targets. > > > > > > Signed-off-by: Thomas Huth <thuth@redhat.com> > > > > It compiles. > > I can't see anything that is target dependent on core.c. > > > > So > > > > Reviewed-by: Juan Quintela <quintela@redhat.com> > > I've merged this into my ppc-for-2.10 tree, on the basis that ppc is > the only user of core.c so far. Any objections? No problem to me. If you want, you can add my: Acked-by: Eduardo Habkost <ehabkost@redhat.com>
diff --git a/hw/cpu/Makefile.objs b/hw/cpu/Makefile.objs index 942a4bb..cd52d20 100644 --- a/hw/cpu/Makefile.objs +++ b/hw/cpu/Makefile.objs @@ -2,5 +2,4 @@ obj-$(CONFIG_ARM11MPCORE) += arm11mpcore.o obj-$(CONFIG_REALVIEW) += realview_mpcore.o obj-$(CONFIG_A9MPCORE) += a9mpcore.o obj-$(CONFIG_A15MPCORE) += a15mpcore.o -obj-y += core.o - +common-obj-y += core.o
There does not seem to be any target specific code in core.c, so we can put it into "common-obj" instead of "obj" to compile it only once for all targets. Signed-off-by: Thomas Huth <thuth@redhat.com> --- hw/cpu/Makefile.objs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)