| Message ID | 20170608092653.25221-4-antoine.tenart@free-electrons.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello! On 6/8/2017 12:26 PM, Antoine Tenart wrote: > Cosmetic patch to use the GENMASK helper for masks. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/net/ethernet/marvell/mvmdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c > index 17b518b13ae3..96af8d57d9e5 100644 > --- a/drivers/net/ethernet/marvell/mvmdio.c > +++ b/drivers/net/ethernet/marvell/mvmdio.c > @@ -138,7 +138,7 @@ static int orion_mdio_read(struct mii_bus *bus, int mii_id, > goto out; > } > > - ret = val & 0xFFFF; > + ret = val & GENMASK(15,0); Need a space after comma. MBR, Sergei
diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c index 17b518b13ae3..96af8d57d9e5 100644 --- a/drivers/net/ethernet/marvell/mvmdio.c +++ b/drivers/net/ethernet/marvell/mvmdio.c @@ -138,7 +138,7 @@ static int orion_mdio_read(struct mii_bus *bus, int mii_id, goto out; } - ret = val & 0xFFFF; + ret = val & GENMASK(15,0); out: mutex_unlock(&dev->lock); return ret;