diff mbox

[U-Boot,01/10] test: pwm: Add a check that dev is not NULL

Message ID 20170607162847.16971-2-sjg@chromium.org
State Accepted
Commit 1a596c44c0967b3191ee278f988d14d6082249e1
Delegated to: Tom Rini
Headers show

Commit Message

Simon Glass June 7, 2017, 4:28 p.m. UTC 
We know that uclass_get_device() does not return NULL for dev when it
succeeds but coverity does not. Add an extra check to hopefully keep it
happy.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 161690)
Fixes: 43b4156 (dm: sandbox: pwm: Add a basic pwm test)
---

 test/dm/pwm.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini June 12, 2017, 10:43 p.m. UTC | #1 
On Wed, Jun 07, 2017 at 10:28:38AM -0600, Simon Glass wrote:

> We know that uclass_get_device() does not return NULL for dev when it
> succeeds but coverity does not. Add an extra check to hopefully keep it
> happy.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reported-by: Coverity (CID: 161690)
> Fixes: 43b4156 (dm: sandbox: pwm: Add a basic pwm test)

Reviewed-by: Tom Rini <trini@konsulko.com>
diff mbox

Patch

diff --git a/test/dm/pwm.c b/test/dm/pwm.c
index f1e38c77dd..6b2dedf6cc 100644
--- a/test/dm/pwm.c
+++ b/test/dm/pwm.c
@@ -18,6 +18,7 @@  static int dm_test_pwm_base(struct unit_test_state *uts)
 	struct udevice *dev;
 
 	ut_assertok(uclass_get_device(UCLASS_PWM, 0, &dev));
+	ut_assertnonnull(dev);
 	ut_assertok(pwm_set_config(dev, 0, 100, 50));
 	ut_assertok(pwm_set_enable(dev, 0, true));
 	ut_assertok(pwm_set_enable(dev, 1, true));