Patchwork [U-Boot,05/13] fix "depend" target in npe directory

login
register
mail settings
Submitter Michael Schwingen
Date Jan. 3, 2011, 1:45 p.m.
Message ID <1294062338-21084-6-git-send-email-michael@schwingen.org>
Download mbox | patch
Permalink /patch/77250/
State Superseded
Headers show

Comments

Michael Schwingen - Jan. 3, 2011, 1:45 p.m.
Signed-off-by: Michael Schwingen <michael@schwingen.org>
---
 arch/arm/cpu/ixp/npe/Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Wolfgang Denk - Jan. 25, 2011, 8:42 p.m.
Dear Michael Schwingen,

In message <1294062338-21084-6-git-send-email-michael@schwingen.org> you wrote:
> 
> Signed-off-by: Michael Schwingen <michael@schwingen.org>
> ---
>  arch/arm/cpu/ixp/npe/Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/cpu/ixp/npe/Makefile b/arch/arm/cpu/ixp/npe/Makefile
> index c756a1d..14ab3c7 100644
> --- a/arch/arm/cpu/ixp/npe/Makefile
> +++ b/arch/arm/cpu/ixp/npe/Makefile
> @@ -27,6 +27,7 @@ LIB := $(obj)libnpe.o
>  
>  LOCAL_CFLAGS  += -I$(TOPDIR)/arch/arm/cpu/ixp/npe/include -DCONFIG_IXP425_COMPONENT_ETHDB -D__linux
>  CFLAGS  += $(LOCAL_CFLAGS)
> +CPPFLAGS  += $(LOCAL_CFLAGS) # needed for depend
>  HOSTCFLAGS  += $(LOCAL_CFLAGS)

It should then be possible to remove the CFLAGS line, right?

Best regards,

Wolfgang Denk
Michael Schwingen - Jan. 26, 2011, 11:22 p.m.
Am 01/25/2011 09:42 PM, schrieb Wolfgang Denk:
> Dear Michael Schwingen,
>
> In message <1294062338-21084-6-git-send-email-michael@schwingen.org> you wrote:
>> Signed-off-by: Michael Schwingen <michael@schwingen.org>
>> ---
>>  arch/arm/cpu/ixp/npe/Makefile |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/cpu/ixp/npe/Makefile b/arch/arm/cpu/ixp/npe/Makefile
>> index c756a1d..14ab3c7 100644
>> --- a/arch/arm/cpu/ixp/npe/Makefile
>> +++ b/arch/arm/cpu/ixp/npe/Makefile
>> @@ -27,6 +27,7 @@ LIB := $(obj)libnpe.o
>>  
>>  LOCAL_CFLAGS  += -I$(TOPDIR)/arch/arm/cpu/ixp/npe/include -DCONFIG_IXP425_COMPONENT_ETHDB -D__linux
>>  CFLAGS  += $(LOCAL_CFLAGS)
>> +CPPFLAGS  += $(LOCAL_CFLAGS) # needed for depend
>>  HOSTCFLAGS  += $(LOCAL_CFLAGS)
> It should then be possible to remove the CFLAGS line, right?
That does not seem to work - I need both. I do not have a full
understanding of the Makefile structures, but I guess the inclusion  of
CPPFLAGS into CFLAGS happens before I can add to CPPFLAGS.

cu
Michael

Patch

diff --git a/arch/arm/cpu/ixp/npe/Makefile b/arch/arm/cpu/ixp/npe/Makefile
index c756a1d..14ab3c7 100644
--- a/arch/arm/cpu/ixp/npe/Makefile
+++ b/arch/arm/cpu/ixp/npe/Makefile
@@ -27,6 +27,7 @@  LIB := $(obj)libnpe.o
 
 LOCAL_CFLAGS  += -I$(TOPDIR)/arch/arm/cpu/ixp/npe/include -DCONFIG_IXP425_COMPONENT_ETHDB -D__linux
 CFLAGS  += $(LOCAL_CFLAGS)
+CPPFLAGS  += $(LOCAL_CFLAGS) # needed for depend
 HOSTCFLAGS  += $(LOCAL_CFLAGS)
 
 COBJS-$(CONFIG_IXP4XX_NPE) := npe.o \