From patchwork Mon Jan 3 08:33:02 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 77237 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 01439B6EE9 for ; Mon, 3 Jan 2011 20:01:40 +1100 (EST) Received: from localhost ([127.0.0.1]:36495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PZgIL-0004PN-9E for incoming@patchwork.ozlabs.org; Mon, 03 Jan 2011 04:01:37 -0500 Received: from [140.186.70.92] (port=52366 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PZfrl-0000ql-Vr for qemu-devel@nongnu.org; Mon, 03 Jan 2011 03:34:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PZfrN-0008Ot-DF for qemu-devel@nongnu.org; Mon, 03 Jan 2011 03:33:46 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:49007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PZfrN-0008OS-1G for qemu-devel@nongnu.org; Mon, 03 Jan 2011 03:33:45 -0500 Received: from smtp01.web.de ( [172.20.0.243]) by fmmailgate01.web.de (Postfix) with ESMTP id B67E6184BFA86; Mon, 3 Jan 2011 09:33:27 +0100 (CET) Received: from [88.64.22.98] (helo=localhost.localdomain) by smtp01.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #2) id 1PZfr5-0007fO-01; Mon, 03 Jan 2011 09:33:27 +0100 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Date: Mon, 3 Jan 2011 09:33:02 +0100 Message-Id: <696f32a087b8b18478321a02bc5792a2d9fe64e7.1294043582.git.jan.kiszka@web.de> X-Mailer: git-send-email 1.7.1 In-Reply-To: References: In-Reply-To: References: X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1+nZlr8uB3ch0fybKCVyxtjTFZHfP90ds3XPgaS sdlGMQEi1Mq48TJ2VgVK7ilnG324OzMLgrgEFQNy3hCPMvQPqD 7l7Bt5tXs= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: Jan Kiszka , qemu-devel@nongnu.org, kvm@vger.kernel.org, Huang Ying Subject: [Qemu-devel] [PATCH v2 12/17] kvm: x86: Drop MCE MSRs write back restrictions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka There is no need to restrict writing back MCE MSRs to reset or full state updates as setting their values has no side effects. Signed-off-by: Jan Kiszka CC: Huang Ying --- target-i386/kvm.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 664a4a0..ef8f6e6 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -866,14 +866,10 @@ static int kvm_put_msrs(CPUState *env, int level) if (env->mcg_cap) { int i; - if (level == KVM_PUT_RESET_STATE) { - kvm_msr_entry_set(&msrs[n++], MSR_MCG_STATUS, env->mcg_status); - } else if (level == KVM_PUT_FULL_STATE) { - kvm_msr_entry_set(&msrs[n++], MSR_MCG_STATUS, env->mcg_status); - kvm_msr_entry_set(&msrs[n++], MSR_MCG_CTL, env->mcg_ctl); - for (i = 0; i < (env->mcg_cap & 0xff) * 4; i++) { - kvm_msr_entry_set(&msrs[n++], MSR_MC0_CTL + i, env->mce_banks[i]); - } + kvm_msr_entry_set(&msrs[n++], MSR_MCG_STATUS, env->mcg_status); + kvm_msr_entry_set(&msrs[n++], MSR_MCG_CTL, env->mcg_ctl); + for (i = 0; i < (env->mcg_cap & 0xff) * 4; i++) { + kvm_msr_entry_set(&msrs[n++], MSR_MC0_CTL + i, env->mce_banks[i]); } } #endif