| Message ID | 1496828798-27548-12-git-send-email-a.perevalov@samsung.com |
|---|---|
| State | New |
| Headers | show |
Alexey Perevalov <a.perevalov@samsung.com> wrote: > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > Signed-off-by: Alexey Perevalov <a.perevalov@samsung.com> > --- > docs/migration.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/docs/migration.txt b/docs/migration.txt > index 1b940a8..4b625ca 100644 > --- a/docs/migration.txt > +++ b/docs/migration.txt > @@ -402,6 +402,16 @@ will now cause the transition from precopy to postcopy. > It can be issued immediately after migration is started or any > time later on. Issuing it after the end of a migration is harmless. > > +Blocktime is a postcopy live migration metric, intended to show > +how long the vCPU was in state of interruptable sleep due to pagefault. > +This value is calculated on destination side. > +To enable postcopy blocktime calculation, enter following command on destination > +monitor: > + > +migrate_set_capability postcopy-blocktime on > + > +Postcopy blocktime can be retrieved by query-migrate qmp command. > + > Note: During the postcopy phase, the bandwidth limits set using > migrate_set_speed is ignored (to avoid delaying requested pages that > the destination is waiting for). Reviewed-by: Juan Quintela <quintela@redhat.com> If you have to respin, I think that put the units would be a good idea. Even you can put the units in the patch where you define the value.
On 06/07/2017 03:52 PM, Juan Quintela wrote: > Alexey Perevalov <a.perevalov@samsung.com> wrote: >> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> >> Signed-off-by: Alexey Perevalov <a.perevalov@samsung.com> >> --- >> docs/migration.txt | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/docs/migration.txt b/docs/migration.txt >> index 1b940a8..4b625ca 100644 >> --- a/docs/migration.txt >> +++ b/docs/migration.txt >> @@ -402,6 +402,16 @@ will now cause the transition from precopy to postcopy. >> It can be issued immediately after migration is started or any >> time later on. Issuing it after the end of a migration is harmless. >> >> +Blocktime is a postcopy live migration metric, intended to show >> +how long the vCPU was in state of interruptable sleep due to pagefault. >> +This value is calculated on destination side. >> +To enable postcopy blocktime calculation, enter following command on destination >> +monitor: >> + >> +migrate_set_capability postcopy-blocktime on >> + >> +Postcopy blocktime can be retrieved by query-migrate qmp command. >> + >> Note: During the postcopy phase, the bandwidth limits set using >> migrate_set_speed is ignored (to avoid delaying requested pages that >> the destination is waiting for). > Reviewed-by: Juan Quintela <quintela@redhat.com> > > If you have to respin, I think that put the units would be a good idea. > Even you can put the units in the patch where you define the value. do you mean to extend tests/postcopy-test.c? > > > >
diff --git a/docs/migration.txt b/docs/migration.txt index 1b940a8..4b625ca 100644 --- a/docs/migration.txt +++ b/docs/migration.txt @@ -402,6 +402,16 @@ will now cause the transition from precopy to postcopy. It can be issued immediately after migration is started or any time later on. Issuing it after the end of a migration is harmless. +Blocktime is a postcopy live migration metric, intended to show +how long the vCPU was in state of interruptable sleep due to pagefault. +This value is calculated on destination side. +To enable postcopy blocktime calculation, enter following command on destination +monitor: + +migrate_set_capability postcopy-blocktime on + +Postcopy blocktime can be retrieved by query-migrate qmp command. + Note: During the postcopy phase, the bandwidth limits set using migrate_set_speed is ignored (to avoid delaying requested pages that the destination is waiting for).