pinctrl: meson-gxbb: remove non-existing pin GPIOX_22
diff mbox

Message ID 77ac1caf-f2b1-efe8-70ea-5a358908cc87@gmail.com
State New
Headers show

Commit Message

Heiner Kallweit June 7, 2017, 5:44 a.m. UTC
After commit 34e61801a3b9 "pinctrl: meson-gxbb: Add missing GPIODV_18
pin entry" I started to get the following warning:

"meson-pinctrl c8834000.periphs:pinctrl@4b0: names 119 do not match
number of GPIOs 120"

It turned out that not the mentioned commit has a problem, it just
revealed another problem which had existed before.

There is no PIN GPIOX_22 on Meson GXBB.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Neil Armstrong June 7, 2017, 11:27 a.m. UTC | #1
On 06/07/2017 07:44 AM, Heiner Kallweit wrote:
> After commit 34e61801a3b9 "pinctrl: meson-gxbb: Add missing GPIODV_18
> pin entry" I started to get the following warning:
> 
> "meson-pinctrl c8834000.periphs:pinctrl@4b0: names 119 do not match
> number of GPIOs 120"
> 
> It turned out that not the mentioned commit has a problem, it just
> revealed another problem which had existed before.
> 
> There is no PIN GPIOX_22 on Meson GXBB.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> index 8b716b93..a879cf07 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> @@ -138,7 +138,6 @@ static const struct pinctrl_pin_desc meson_gxbb_periphs_pins[] = {
>  	MESON_PIN(GPIOX_19, EE_OFF),
>  	MESON_PIN(GPIOX_20, EE_OFF),
>  	MESON_PIN(GPIOX_21, EE_OFF),
> -	MESON_PIN(GPIOX_22, EE_OFF),
>  
>  	MESON_PIN(GPIOCLK_0, EE_OFF),
>  	MESON_PIN(GPIOCLK_1, EE_OFF),
> 

Fixes: 468c234f9ed7 ("pinctrl: amlogic: Add support for Amlogic Meson GXBB SoC")
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Thanks for the patch !

Neil
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij June 9, 2017, 7:25 a.m. UTC | #2
On Wed, Jun 7, 2017 at 7:44 AM, Heiner Kallweit <hkallweit1@gmail.com> wrote:

> After commit 34e61801a3b9 "pinctrl: meson-gxbb: Add missing GPIODV_18
> pin entry" I started to get the following warning:
>
> "meson-pinctrl c8834000.periphs:pinctrl@4b0: names 119 do not match
> number of GPIOs 120"
>
> It turned out that not the mentioned commit has a problem, it just
> revealed another problem which had existed before.
>
> There is no PIN GPIOX_22 on Meson GXBB.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Patch applied with Neil's tags.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
index 8b716b93..a879cf07 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
@@ -138,7 +138,6 @@  static const struct pinctrl_pin_desc meson_gxbb_periphs_pins[] = {
 	MESON_PIN(GPIOX_19, EE_OFF),
 	MESON_PIN(GPIOX_20, EE_OFF),
 	MESON_PIN(GPIOX_21, EE_OFF),
-	MESON_PIN(GPIOX_22, EE_OFF),
 
 	MESON_PIN(GPIOCLK_0, EE_OFF),
 	MESON_PIN(GPIOCLK_1, EE_OFF),