Patchwork disable libiberty for picochip build.

login
register
mail settings
Submitter Ralf Wildenhues
Date Jan. 2, 2011, 4:40 p.m.
Message ID <20110102164020.GK10951@gmx.de>
Download mbox | patch
Permalink /patch/77194/
State New
Headers show

Comments

Ralf Wildenhues - Jan. 2, 2011, 4:40 p.m.
* Hari Sandanagobalane wrote on Thu, Dec 23, 2010 at 05:11:31PM CET:
> On 23/12/10 10:39, Ralf Wildenhues wrote:
> >* Hari Sandanagobalane wrote on Wed, Dec 22, 2010 at 11:35:14AM CET:
> >>I have now committed (168165) the following change in mainline to disable
> >>libiberty for picochip builds. Thanks
> >
> >This patch is missing the regeneration of the generated configure
> >script.  Also, toplevel needs to be synced to the src repository.
> >Please ping me if you need someone to do the latter for you.

> I have regenerated the configure script and checked the change in.
> Would you be able to tell me what you mean by the
> "synced to the src repository"?

That is described at
<http://gcc.gnu.org/codingconventions.html#upstream> and
<http://sourceware.org/cgi-bin/cvsweb.cgi/src/MAINTAINERS?rev=1.36&content-type=text/x-cvsweb-markup&cvsroot=src>
and is about files shared between GCC, binutils, gdb, and other
packages.

> If you can do it, that is great. But, i would like to know what
> steps i missed so i do it right the next time!

If you don't have write access to the src CVS repository, please mention
that you need somebody to sync for you.

FYI, I'm committing as below to src.

In your commit log entries, please put two spaces between name and email
address.

Thanks,
Ralf

2011-01-02  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	Sync from GCC:
	2010-12-22  Hariharan Sandanagobalane  <hariharan@picochip.com>

	* configure.ac: (picochip): Disable libiberty.
	* configure: Regenerate.
H.J. Lu - Jan. 2, 2011, 4:44 p.m.
On Sun, Jan 2, 2011 at 8:40 AM, Ralf Wildenhues <Ralf.Wildenhues@gmx.de> wrote:
> * Hari Sandanagobalane wrote on Thu, Dec 23, 2010 at 05:11:31PM CET:
>> On 23/12/10 10:39, Ralf Wildenhues wrote:
>> >* Hari Sandanagobalane wrote on Wed, Dec 22, 2010 at 11:35:14AM CET:
>> >>I have now committed (168165) the following change in mainline to disable
>> >>libiberty for picochip builds. Thanks
>> >
>> >This patch is missing the regeneration of the generated configure
>> >script.  Also, toplevel needs to be synced to the src repository.
>> >Please ping me if you need someone to do the latter for you.
>
>> I have regenerated the configure script and checked the change in.
>> Would you be able to tell me what you mean by the
>> "synced to the src repository"?
>
> That is described at
> <http://gcc.gnu.org/codingconventions.html#upstream> and
> <http://sourceware.org/cgi-bin/cvsweb.cgi/src/MAINTAINERS?rev=1.36&content-type=text/x-cvsweb-markup&cvsroot=src>
> and is about files shared between GCC, binutils, gdb, and other
> packages.
>
>> If you can do it, that is great. But, i would like to know what
>> steps i missed so i do it right the next time!
>
> If you don't have write access to the src CVS repository, please mention
> that you need somebody to sync for you.
>
> FYI, I'm committing as below to src.
>
> In your commit log entries, please put two spaces between name and email
> address.
>
> Thanks,
> Ralf
>
> 2011-01-02  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
>
>        Sync from GCC:
>        2010-12-22  Hariharan Sandanagobalane  <hariharan@picochip.com>
>
>        * configure.ac: (picochip): Disable libiberty.
>        * configure: Regenerate.
>
>

Shouldn't we also sync ChangeLog in libiberty?
Ralf Wildenhues - Jan. 2, 2011, 4:47 p.m.
* H.J. Lu wrote on Sun, Jan 02, 2011 at 05:44:06PM CET:
> 
> Shouldn't we also sync ChangeLog in libiberty?

Last time I asked, libiberty was robo-synced.  Has that changed, DJ?

Thanks,
Ralf
Hariharan Sandanagobalane - Jan. 4, 2011, 9:36 a.m.
Thanks a bunch, Ralf.

Cheers
Hari

On 02/01/11 16:40, Ralf Wildenhues wrote:
> * Hari Sandanagobalane wrote on Thu, Dec 23, 2010 at 05:11:31PM CET:
>> On 23/12/10 10:39, Ralf Wildenhues wrote:
>>> * Hari Sandanagobalane wrote on Wed, Dec 22, 2010 at 11:35:14AM CET:
>>>> I have now committed (168165) the following change in mainline to disable
>>>> libiberty for picochip builds. Thanks
>>>
>>> This patch is missing the regeneration of the generated configure
>>> script.  Also, toplevel needs to be synced to the src repository.
>>> Please ping me if you need someone to do the latter for you.
>
>> I have regenerated the configure script and checked the change in.
>> Would you be able to tell me what you mean by the
>> "synced to the src repository"?
>
> That is described at
> <http://gcc.gnu.org/codingconventions.html#upstream>  and
> <http://sourceware.org/cgi-bin/cvsweb.cgi/src/MAINTAINERS?rev=1.36&content-type=text/x-cvsweb-markup&cvsroot=src>
> and is about files shared between GCC, binutils, gdb, and other
> packages.
>
>> If you can do it, that is great. But, i would like to know what
>> steps i missed so i do it right the next time!
>
> If you don't have write access to the src CVS repository, please mention
> that you need somebody to sync for you.
>
> FYI, I'm committing as below to src.
>
> In your commit log entries, please put two spaces between name and email
> address.
>
> Thanks,
> Ralf
>
> 2011-01-02  Ralf Wildenhues<Ralf.Wildenhues@gmx.de>
>
> 	Sync from GCC:
> 	2010-12-22  Hariharan Sandanagobalane<hariharan@picochip.com>
>
> 	* configure.ac: (picochip): Disable libiberty.
> 	* configure: Regenerate.
>
> Index: configure.ac
> ===================================================================
> RCS file: /cvs/src/src/configure.ac,v
> retrieving revision 1.122
> diff -u -r1.122 configure.ac
> --- configure.ac	10 Dec 2010 14:50:10 -0000	1.122
> +++ configure.ac	2 Jan 2011 16:35:50 -0000
> @@ -916,6 +916,9 @@
>     mt-*-*)
>       noconfigdirs="$noconfigdirs sim"
>       ;;
> +  picochip-*-*)
> +    noconfigdirs="$noconfigdirs target-libiberty"
> +    ;;
>     powerpc-*-aix*)
>       # copied from rs6000-*-* entry
>       noconfigdirs="$noconfigdirs gprof target-libgloss target-libssp target-newlib ${libgcj}"
>

Patch

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/configure.ac,v
retrieving revision 1.122
diff -u -r1.122 configure.ac
--- configure.ac	10 Dec 2010 14:50:10 -0000	1.122
+++ configure.ac	2 Jan 2011 16:35:50 -0000
@@ -916,6 +916,9 @@ 
   mt-*-*)
     noconfigdirs="$noconfigdirs sim"
     ;;
+  picochip-*-*)
+    noconfigdirs="$noconfigdirs target-libiberty"
+    ;;
   powerpc-*-aix*)
     # copied from rs6000-*-* entry
     noconfigdirs="$noconfigdirs gprof target-libgloss target-libssp target-newlib ${libgcj}"