| Message ID | 149676256806.31274.17021734547869850899.stgit@bahia.lab.toulouse-stg.fr.ibm.com |
|---|---|
| State | New |
| Headers | show |
On 06/06/2017 12:22 PM, Greg Kurz wrote: > Signed-off-by: Greg Kurz <groug@kaod.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > target/ppc/kvm.c | 4 ++-- > target/ppc/kvm_ppc.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c > index 51249ce79e55..88817620766c 100644 > --- a/target/ppc/kvm.c > +++ b/target/ppc/kvm.c > @@ -478,7 +478,7 @@ static void kvm_fixup_page_sizes(PowerPCCPU *cpu) > } > } > > -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path) > +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path) > { > Object *mem_obj = object_resolve_path(obj_path, NULL); > char *mempath = object_property_get_str(mem_obj, "mem-path", NULL); > @@ -499,7 +499,7 @@ static inline void kvm_fixup_page_sizes(PowerPCCPU *cpu) > { > } > > -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path) > +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path) > { > return true; > } > diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h > index f48243d13ffc..fd72d6b05a98 100644 > --- a/target/ppc/kvm_ppc.h > +++ b/target/ppc/kvm_ppc.h > @@ -64,7 +64,7 @@ int kvmppc_enable_hwrng(void); > int kvmppc_put_books_sregs(PowerPCCPU *cpu); > PowerPCCPUClass *kvm_ppc_get_host_cpu_class(void); > > -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path); > +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path); > > #else > > >
A short patch description for saying why this is appropriate would be nice :-) On 06.06.2017 17:22, Greg Kurz wrote: > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > target/ppc/kvm.c | 4 ++-- > target/ppc/kvm_ppc.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c > index 51249ce79e55..88817620766c 100644 > --- a/target/ppc/kvm.c > +++ b/target/ppc/kvm.c > @@ -478,7 +478,7 @@ static void kvm_fixup_page_sizes(PowerPCCPU *cpu) > } > } > > -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path) > +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path) > { > Object *mem_obj = object_resolve_path(obj_path, NULL); > char *mempath = object_property_get_str(mem_obj, "mem-path", NULL); > @@ -499,7 +499,7 @@ static inline void kvm_fixup_page_sizes(PowerPCCPU *cpu) > { > } > > -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path) > +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path) > { > return true; > } > diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h > index f48243d13ffc..fd72d6b05a98 100644 > --- a/target/ppc/kvm_ppc.h > +++ b/target/ppc/kvm_ppc.h > @@ -64,7 +64,7 @@ int kvmppc_enable_hwrng(void); > int kvmppc_put_books_sregs(PowerPCCPU *cpu); > PowerPCCPUClass *kvm_ppc_get_host_cpu_class(void); > > -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path); > +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path); > > #else I think you could also add the "const" to the "static inline bool kvmppc_is_mem_backend_page_size_ok()" later in that header. Thomas
On Tue, 06 Jun 2017 17:22:48 +0200 Greg Kurz <groug@kaod.org> wrote: > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > target/ppc/kvm.c | 4 ++-- > target/ppc/kvm_ppc.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c > index 51249ce79e55..88817620766c 100644 > --- a/target/ppc/kvm.c > +++ b/target/ppc/kvm.c > @@ -478,7 +478,7 @@ static void kvm_fixup_page_sizes(PowerPCCPU *cpu) > } > } > > -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path) > +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path) > { > Object *mem_obj = object_resolve_path(obj_path, NULL); > char *mempath = object_property_get_str(mem_obj, "mem-path", NULL); > @@ -499,7 +499,7 @@ static inline void kvm_fixup_page_sizes(PowerPCCPU *cpu) > { > } > > -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path) > +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path) > { > return true; > } > diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h > index f48243d13ffc..fd72d6b05a98 100644 > --- a/target/ppc/kvm_ppc.h > +++ b/target/ppc/kvm_ppc.h > @@ -64,7 +64,7 @@ int kvmppc_enable_hwrng(void); > int kvmppc_put_books_sregs(PowerPCCPU *cpu); > PowerPCCPUClass *kvm_ppc_get_host_cpu_class(void); > > -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path); > +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path); > > #else > Dumb me forgot to patch the inline stub... Will send a v2 for this patch only.
diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 51249ce79e55..88817620766c 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -478,7 +478,7 @@ static void kvm_fixup_page_sizes(PowerPCCPU *cpu) } } -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path) +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path) { Object *mem_obj = object_resolve_path(obj_path, NULL); char *mempath = object_property_get_str(mem_obj, "mem-path", NULL); @@ -499,7 +499,7 @@ static inline void kvm_fixup_page_sizes(PowerPCCPU *cpu) { } -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path) +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path) { return true; } diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h index f48243d13ffc..fd72d6b05a98 100644 --- a/target/ppc/kvm_ppc.h +++ b/target/ppc/kvm_ppc.h @@ -64,7 +64,7 @@ int kvmppc_enable_hwrng(void); int kvmppc_put_books_sregs(PowerPCCPU *cpu); PowerPCCPUClass *kvm_ppc_get_host_cpu_class(void); -bool kvmppc_is_mem_backend_page_size_ok(char *obj_path); +bool kvmppc_is_mem_backend_page_size_ok(const char *obj_path); #else
Signed-off-by: Greg Kurz <groug@kaod.org> --- target/ppc/kvm.c | 4 ++-- target/ppc/kvm_ppc.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)