| Message ID | 1496756553-19901-2-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
On 6 June 2017 at 07:42, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > After rebasing to u-boot-rockchip/master@2b19b2f, buildman fails for > rv1108 with: > ../drivers/clk/rockchip/clk_rv1108.c: In function 'rv1108_clk_probe': > ../drivers/clk/rockchip/clk_rv1108.c:191:22: warning: implicit declaration of function 'dev_get_addr' [-Wimplicit-function-declaration] > priv->cru = (struct rv1108_cru *)dev_get_addr(dev); > > This change tracks the dev_get_addr rename, which didn't make it into > the rv1108 clk driver. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > > --- > > Changes in v2: > - (new patch) rename dev_get_addr in the RV1108 clk-driver to fix a > buildman failure for u-boot-rockchip/master@2b19b2f > > drivers/clk/rockchip/clk_rv1108.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Simon Glass <sjg@chromium.org>
Hi Philipp: 2017-06-06 21:42 GMT+08:00 Philipp Tomsich < philipp.tomsich@theobroma-systems.com>: > After rebasing to u-boot-rockchip/master@2b19b2f, buildman fails for > rv1108 with: > ../drivers/clk/rockchip/clk_rv1108.c: In function 'rv1108_clk_probe': > ../drivers/clk/rockchip/clk_rv1108.c:191:22: warning: implicit > declaration of function 'dev_get_addr' [-Wimplicit-function-declaration] > priv->cru = (struct rv1108_cru *)dev_get_addr(dev); > > This change tracks the dev_get_addr rename, which didn't make it into > the rv1108 clk driver. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > > --- > Tested-by: Andy Yan <andy.yan@rock-chips.com> Thanks. > > Changes in v2: > - (new patch) rename dev_get_addr in the RV1108 clk-driver to fix a > buildman failure for u-boot-rockchip/master@2b19b2f > > drivers/clk/rockchip/clk_rv1108.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/rockchip/clk_rv1108.c b/drivers/clk/rockchip/clk_ > rv1108.c > index 0946dab..0a3ba3b 100644 > --- a/drivers/clk/rockchip/clk_rv1108.c > +++ b/drivers/clk/rockchip/clk_rv1108.c > @@ -188,7 +188,7 @@ static int rv1108_clk_probe(struct udevice *dev) > { > struct rv1108_clk_priv *priv = dev_get_priv(dev); > > - priv->cru = (struct rv1108_cru *)dev_get_addr(dev); > + priv->cru = (struct rv1108_cru *)devfdt_get_addr(dev); > > rkclk_init(priv->cru); > > -- > 2.1.4 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot >
Hi Philipp: 2017-06-06 21:42 GMT+08:00 Philipp Tomsich < philipp.tomsich@theobroma-systems.com>: > After rebasing to u-boot-rockchip/master@2b19b2f, buildman fails for > rv1108 with: > ../drivers/clk/rockchip/clk_rv1108.c: In function 'rv1108_clk_probe': > ../drivers/clk/rockchip/clk_rv1108.c:191:22: warning: implicit > declaration of function 'dev_get_addr' [-Wimplicit-function-declaration] > priv->cru = (struct rv1108_cru *)dev_get_addr(dev); > > This change tracks the dev_get_addr rename, which didn't make it into > the rv1108 clk driver. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > > --- > Tested-by: Andy Yan <andy.yan@rock-chips.com> Thanks. > > Changes in v2: > - (new patch) rename dev_get_addr in the RV1108 clk-driver to fix a > buildman failure for u-boot-rockchip/master@2b19b2f > > drivers/clk/rockchip/clk_rv1108.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to u-boot-rockchip, thanks!
diff --git a/drivers/clk/rockchip/clk_rv1108.c b/drivers/clk/rockchip/clk_rv1108.c index 0946dab..0a3ba3b 100644 --- a/drivers/clk/rockchip/clk_rv1108.c +++ b/drivers/clk/rockchip/clk_rv1108.c @@ -188,7 +188,7 @@ static int rv1108_clk_probe(struct udevice *dev) { struct rv1108_clk_priv *priv = dev_get_priv(dev); - priv->cru = (struct rv1108_cru *)dev_get_addr(dev); + priv->cru = (struct rv1108_cru *)devfdt_get_addr(dev); rkclk_init(priv->cru);
After rebasing to u-boot-rockchip/master@2b19b2f, buildman fails for rv1108 with: ../drivers/clk/rockchip/clk_rv1108.c: In function 'rv1108_clk_probe': ../drivers/clk/rockchip/clk_rv1108.c:191:22: warning: implicit declaration of function 'dev_get_addr' [-Wimplicit-function-declaration] priv->cru = (struct rv1108_cru *)dev_get_addr(dev); This change tracks the dev_get_addr rename, which didn't make it into the rv1108 clk driver. Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> --- Changes in v2: - (new patch) rename dev_get_addr in the RV1108 clk-driver to fix a buildman failure for u-boot-rockchip/master@2b19b2f drivers/clk/rockchip/clk_rv1108.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)