diff mbox

[3/6] migration: use compat bit for global_state

Message ID 1496745042-2379-4-git-send-email-peterx@redhat.com
State New
Headers show

Commit Message

Peter Xu June 6, 2017, 10:30 a.m. UTC
Removing two callers of global_state_set_optional() since now we can use
HW_COMPAT_2_3. However there is still one more caller (xen_init), so we
still need to keep the function until it disappears.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 hw/i386/pc_piix.c   | 1 -
 hw/ppc/spapr.c      | 1 -
 include/hw/compat.h | 4 ++++
 3 files changed, 4 insertions(+), 2 deletions(-)

Comments

Juan Quintela June 7, 2017, 5:44 p.m. UTC | #1
Peter Xu <peterx@redhat.com> wrote:
> Removing two callers of global_state_set_optional() since now we can use
> HW_COMPAT_2_3. However there is still one more caller (xen_init), so we
> still need to keep the function until it disappears.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Ah, you do it here, nice.
diff mbox

Patch

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 2234bd0..c83cec5 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -317,7 +317,6 @@  static void pc_compat_2_3(MachineState *machine)
     if (kvm_enabled()) {
         pcms->smm = ON_OFF_AUTO_OFF;
     }
-    global_state_set_optional();
     savevm_skip_configuration();
 }
 
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index ab3aab1..3e78bb9 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3593,7 +3593,6 @@  static void spapr_machine_2_3_instance_options(MachineState *machine)
 {
     spapr_machine_2_4_instance_options(machine);
     savevm_skip_section_footers();
-    global_state_set_optional();
     savevm_skip_configuration();
 }
 
diff --git a/include/hw/compat.h b/include/hw/compat.h
index 400c64b..5b5c8de 100644
--- a/include/hw/compat.h
+++ b/include/hw/compat.h
@@ -177,6 +177,10 @@ 
         .driver   = TYPE_PCI_DEVICE,\
         .property = "x-pcie-lnksta-dllla",\
         .value    = "off",\
+    },{\
+        .driver   = "migration",\
+        .property = "store-global-state",\
+        .value    = "off",\
     },
 
 #define HW_COMPAT_2_2 \