From patchwork Fri Dec 31 18:20:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 77095 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A81BDB7082 for ; Sat, 1 Jan 2011 05:20:03 +1100 (EST) Received: (qmail 22952 invoked by alias); 31 Dec 2010 18:20:00 -0000 Received: (qmail 22944 invoked by uid 22791); 31 Dec 2010 18:19:59 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 31 Dec 2010 18:19:53 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 298EFCB0234; Fri, 31 Dec 2010 19:19:51 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wYC7v-zRRNdy; Fri, 31 Dec 2010 19:19:51 +0100 (CET) Received: from new-host.home (ADijon-552-1-100-214.w90-33.abo.wanadoo.fr [90.33.59.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id C9ABACB01D3; Fri, 31 Dec 2010 19:19:50 +0100 (CET) From: Eric Botcazou To: Kai Tietz Subject: Re: [patch c++, ada, middle-end]: PR 38662 - __fastcall confuses a function's throw() specification Date: Fri, 31 Dec 2010 19:20:25 +0100 User-Agent: KMail/1.9.9 Cc: gcc-patches@gcc.gnu.org, Jason Merrill , Richard Guenther , dewar@gnat.com References: <201012311833.22669.ebotcazou@adacore.com> In-Reply-To: MIME-Version: 1.0 Message-Id: <201012311920.25995.ebotcazou@adacore.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > Good, I remove this part of the patch. I wasn't quite sure if there > would be some use of METHOD_TYPE. As by grepping through ada's gcc > tree I found some hits for it. Indeed, removed thusly, thanks for pointing this out. 2010-12-31 Eric Botcazou * gcc-interface/decl.c (substitute_in_type): Do not deal with LANG_TYPE, METHOD_TYPE or OFFSET_TYPE. * gcc-interface/utils.c (handle_vector_size_attribute): Do not deal with METHOD_TYPE or OFFSET_TYPE. Index: gcc-interface/utils.c =================================================================== --- gcc-interface/utils.c (revision 168068) +++ gcc-interface/utils.c (working copy) @@ -5313,9 +5313,7 @@ handle_vector_size_attribute (tree *node while (POINTER_TYPE_P (type) || TREE_CODE (type) == FUNCTION_TYPE - || TREE_CODE (type) == METHOD_TYPE - || TREE_CODE (type) == ARRAY_TYPE - || TREE_CODE (type) == OFFSET_TYPE) + || TREE_CODE (type) == ARRAY_TYPE) type = TREE_TYPE (type); /* Get the mode of the type being modified. */ Index: gcc-interface/decl.c =================================================================== --- gcc-interface/decl.c (revision 168068) +++ gcc-interface/decl.c (working copy) @@ -8638,10 +8638,7 @@ substitute_in_type (tree t, tree f, tree return build_complex_type (nt); - case OFFSET_TYPE: - case METHOD_TYPE: case FUNCTION_TYPE: - case LANG_TYPE: /* These should never show up here. */ gcc_unreachable ();