| Message ID | 20170602091800.189904-1-c_mykolak@mellanox.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, Jun 2, 2017 at 6:48 PM, Mykola Kostenok <c_mykolak@mellanox.com> wrote: > Add ncsi 2nd boot aspeed g5 configuration header. > It based on ast-g5-ncsi.h extended with defines for memtest. I was hoping to merge these changes into the normal configurations, instead of having a separate config. The only difference is the presence of the SYS_MEMTEST defines. > +/* platform.S settings */ > +#define CONFIG_DRAM_ECC_SIZE 0x10000000 > + > +#define CONFIG_SYS_MEMTEST_SIZE 128 * 1024 * 1024 /* 128MB */ > +#define CONFIG_SYS_MEMTEST_START CONFIG_SYS_SDRAM_BASE > +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START + CONFIG_SYS_MEMTEST_SIZE) I was looking at the u-boot tree, and it appears that these SYS_MEMTEST defines are used by the mtest command, and the mtest command is deprecated: 2. The "mtest" command. This is probably the best known memory test utility in U-Boot. Unfortunately, it is also the most problematic, and the most useless one. Because of these issues, the "mtest" command is considered depre- cated. It should not be enabled in most normal ports of U-Boot, especially not in production. If you really need a memory test, then see 1. and 3. above resp. below. Are you sure that you want to enable the mtest command? Cheers, Joel > + > +#endif /* __AST_G5_NCSI_2BOOT_CONFIG_H */ > -- > 2.11.0 >
Best regards. Mykola Kostenok. > -----Original Message----- > From: joel.stan@gmail.com [mailto:joel.stan@gmail.com] On Behalf Of Joel > Stanley > Sent: Monday, June 26, 2017 1:13 PM > To: Mykola Kostenok <c_mykolak@mellanox.com> > Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org> > Subject: Re: [PATCH u-boot v2016.07-aspeed-openbmc] Add ast-g5 ncsi 2nd > boot config. > > On Fri, Jun 2, 2017 at 6:48 PM, Mykola Kostenok > <c_mykolak@mellanox.com> wrote: > > Add ncsi 2nd boot aspeed g5 configuration header. > > It based on ast-g5-ncsi.h extended with defines for memtest. > > I was hoping to merge these changes into the normal configurations, instead > of having a separate config. > > The only difference is the presence of the SYS_MEMTEST defines. > > > +/* platform.S settings */ > > +#define CONFIG_DRAM_ECC_SIZE 0x10000000 > > + > > +#define CONFIG_SYS_MEMTEST_SIZE 128 * 1024 * 1024 /* 128MB */ > > +#define CONFIG_SYS_MEMTEST_START CONFIG_SYS_SDRAM_BASE > > +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START + > > +CONFIG_SYS_MEMTEST_SIZE) > > I was looking at the u-boot tree, and it appears that these SYS_MEMTEST > defines are used by the mtest command, and the mtest command is > deprecated: > > > 2. The "mtest" command. > > This is probably the best known memory test utility in U-Boot. > Unfortunately, it is also the most problematic, and the most > useless one. > > Because of these issues, the "mtest" command is considered depre- > cated. It should not be enabled in most normal ports of U-Boot, > especially not in production. If you really need a memory test, > then see 1. and 3. above resp. below. > > Are you sure that you want to enable the mtest command? > We added mtest, because it was the production requirement. Following the reference from u-boot you pointed out: +3. The most thorough memory test facility is available as part of the + POST (Power-On Self Test) sub-system, see "post/drivers/memory.c". I see that in post/Makefile there is no entry for ARM obj-$(CONFIG_ARM) += cpu/arm/ I’ll check it. If it’s work – would be good with us. > Cheers, > > Joel > > > > + > > +#endif /* __AST_G5_NCSI_2BOOT_CONFIG_H */ > > -- > > 2.11.0 > >
diff --git a/include/configs/ast-g5-ncsi-2boot.h b/include/configs/ast-g5-ncsi-2boot.h new file mode 100644 index 0000000000..8d4c960451 --- /dev/null +++ b/include/configs/ast-g5-ncsi-2boot.h @@ -0,0 +1,33 @@ +/* + * Copyright (C) 2017 Mellanox Technologies Ltd. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + */ + +#ifndef __AST_G5_NCSI_2BOOT_CONFIG_H +#define __AST_G5_NCSI_2BOOT_CONFIG_H + +#define CONFIG_ARCH_AST2500 +#define CONFIG_SYS_LOAD_ADDR 0x83000000 + +#include <configs/ast-common.h> + +/* arm1176/start.S */ +#define CONFIG_SYS_UBOOT_BASE CONFIG_SYS_TEXT_BASE + +/* Ethernet */ +#define CONFIG_LIB_RAND +#define CONFIG_ASPEEDNIC + +/* platform.S settings */ +#define CONFIG_DRAM_ECC_SIZE 0x10000000 + +#define CONFIG_SYS_MEMTEST_SIZE 128 * 1024 * 1024 /* 128MB */ +#define CONFIG_SYS_MEMTEST_START CONFIG_SYS_SDRAM_BASE +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START + CONFIG_SYS_MEMTEST_SIZE) + +#endif /* __AST_G5_NCSI_2BOOT_CONFIG_H */
Add ncsi 2nd boot aspeed g5 configuration header. It based on ast-g5-ncsi.h extended with defines for memtest. Signed-off-by: Mykola Kostenok <c_mykolak@mellanox.com> --- include/configs/ast-g5-ncsi-2boot.h | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 include/configs/ast-g5-ncsi-2boot.h