| Message ID | 20170602052107.22709-2-kai.heng.feng@canonical.com |
|---|---|
| State | New |
| Headers | show |
On 02/06/17 06:21, Kai-Heng Feng wrote: > From: Kai Heng Feng <kai.heng.feng@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1678590 > > The battery can only be detected after AC power adapter event. > > Adding the machine to acpi_rev_dmi_table[] can work around this > issue. > > Link: https://bugs.launchpad.net/bugs/1678590 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=105721 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > (cherry picked from commit 2cff319e9666f534a7538aa1f4178d1f799b068a) > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > drivers/acpi/blacklist.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c > index 4421f7c9981c..bb542acc0574 100644 > --- a/drivers/acpi/blacklist.c > +++ b/drivers/acpi/blacklist.c > @@ -188,6 +188,14 @@ static struct dmi_system_id acpi_rev_dmi_table[] __initdata = { > DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"), > }, > }, > + { > + .callback = dmi_enable_rev_override, > + .ident = "DELL Inspiron 7537", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7537"), > + }, > + }, > #endif > {} > }; > Thanks for the fix. It's upstream, tested and is constrained to just one specific machine and works around the broken _REV. Is there any reason it's not applicable for other releases too (Xenial, Yaketty)? Acked-by: Colin Ian King <colin.king@canonical.com>
On Fri, Jun 2, 2017 at 3:57 PM, Colin Ian King <colin.king@canonical.com> wrote: > On 02/06/17 06:21, Kai-Heng Feng wrote: >> From: Kai Heng Feng <kai.heng.feng@canonical.com> >> >> BugLink: https://bugs.launchpad.net/bugs/1678590 >> >> The battery can only be detected after AC power adapter event. >> >> Adding the machine to acpi_rev_dmi_table[] can work around this >> issue. >> >> Link: https://bugs.launchpad.net/bugs/1678590 >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=105721 >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> >> (cherry picked from commit 2cff319e9666f534a7538aa1f4178d1f799b068a) >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >> --- >> drivers/acpi/blacklist.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c >> index 4421f7c9981c..bb542acc0574 100644 >> --- a/drivers/acpi/blacklist.c >> +++ b/drivers/acpi/blacklist.c >> @@ -188,6 +188,14 @@ static struct dmi_system_id acpi_rev_dmi_table[] __initdata = { >> DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"), >> }, >> }, >> + { >> + .callback = dmi_enable_rev_override, >> + .ident = "DELL Inspiron 7537", >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), >> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7537"), >> + }, >> + }, >> #endif >> {} >> }; >> > > Thanks for the fix. It's upstream, tested and is constrained to just one > specific machine and works around the broken _REV. > > Is there any reason it's not applicable for other releases too (Xenial, > Yaketty)? Because the user uses Zesty. I'll make a patch for Xenial/Yakkety too.
On Fri, Jun 02, 2017 at 01:21:07PM +0800, Kai-Heng Feng wrote: > From: Kai Heng Feng <kai.heng.feng@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1678590 > > The battery can only be detected after AC power adapter event. > > Adding the machine to acpi_rev_dmi_table[] can work around this > issue. > > Link: https://bugs.launchpad.net/bugs/1678590 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=105721 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > (cherry picked from commit 2cff319e9666f534a7538aa1f4178d1f799b068a) > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Clean cherry pick, limited scope, positive testing. Acked-by: Seth Forshee <seth.forshee@canonical.com> Applied to artful/master-next.
Applied to zesty/master-next. Thanks.
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c index 4421f7c9981c..bb542acc0574 100644 --- a/drivers/acpi/blacklist.c +++ b/drivers/acpi/blacklist.c @@ -188,6 +188,14 @@ static struct dmi_system_id acpi_rev_dmi_table[] __initdata = { DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"), }, }, + { + .callback = dmi_enable_rev_override, + .ident = "DELL Inspiron 7537", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7537"), + }, + }, #endif {} };