| Message ID | CAKjxQHmPCQsDjyi-AjXAJFtcbNdsYKG3OYwkRJ9PvVzzhncwug@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
cc: Matthew. ping. On Thu, Jun 1, 2017 at 3:35 PM, Paul Hua <paul.hua.gm@gmail.com> wrote: > Hi, > > There are duplicate testcase in gcc.target/mips dir. > > div-5.c same as div-9.c. > div-6.c same as div-10.c. > div-7.c same as div-11.c. > div-8.c same as div-12.c. > > Is this deliberate? > > Otherwise, the attached patch fixing this. > > > Paul. > > ***ChangeLog*** > > 2017-06-01 Chenghua Xu <paul.hua.gm@gmail.com> > > Remove duplicate div-x testcase. > * gcc.target/mips/div-9.c: Delete. > * gcc.target/mips/div-10.c: Ditto. > * gcc.target/mips/div-11.c: Ditto. > * gcc.target/mips/div-12.c: Ditto.
Hi Paul, Paul Hua <paul.hua.gm@gmail.com> writes: > cc: Matthew. > > ping. Sorry a little slow on the reply. > On Thu, Jun 1, 2017 at 3:35 PM, Paul Hua <paul.hua.gm@gmail.com> wrote: > > Hi, > > > > There are duplicate testcase in gcc.target/mips dir. > > > > div-5.c same as div-9.c. > > div-6.c same as div-10.c. > > div-7.c same as div-11.c. > > div-8.c same as div-12.c. > > > > Is this deliberate? I see no evidence of this being deliberate and has been like this since the original commit. > > Otherwise, the attached patch fixing this. > > > > > > Paul. > > > > ***ChangeLog*** > > > > 2017-06-01 Chenghua Xu <paul.hua.gm@gmail.com> > > > > Remove duplicate div-x testcase. These kind of comments don't tend to go in a changelog. > > * gcc.target/mips/div-9.c: Delete. You could say "Delete duplicate test" here if you want though. > > * gcc.target/mips/div-10.c: Ditto. > > * gcc.target/mips/div-11.c: Ditto. > > * gcc.target/mips/div-12.c: Ditto. Otherwise OK. I can't remember if you have write access let me know if you need it committing. Thanks for finding this. Matthew
Commited as r248868. Thanks. Paul. On Mon, Jun 5, 2017 at 4:41 AM, Matthew Fortune <Matthew.Fortune@imgtec.com> wrote: > Hi Paul, > > Paul Hua <paul.hua.gm@gmail.com> writes: >> cc: Matthew. >> >> ping. > > Sorry a little slow on the reply. > >> On Thu, Jun 1, 2017 at 3:35 PM, Paul Hua <paul.hua.gm@gmail.com> wrote: >> > Hi, >> > >> > There are duplicate testcase in gcc.target/mips dir. >> > >> > div-5.c same as div-9.c. >> > div-6.c same as div-10.c. >> > div-7.c same as div-11.c. >> > div-8.c same as div-12.c. >> > >> > Is this deliberate? > > I see no evidence of this being deliberate and has been like this since > the original commit. > >> > Otherwise, the attached patch fixing this. >> > >> > >> > Paul. >> > >> > ***ChangeLog*** >> > >> > 2017-06-01 Chenghua Xu <paul.hua.gm@gmail.com> >> > >> > Remove duplicate div-x testcase. > > These kind of comments don't tend to go in a changelog. > >> > * gcc.target/mips/div-9.c: Delete. > > You could say "Delete duplicate test" here if you want though. > >> > * gcc.target/mips/div-10.c: Ditto. >> > * gcc.target/mips/div-11.c: Ditto. >> > * gcc.target/mips/div-12.c: Ditto. > > Otherwise OK. I can't remember if you have write access let me know > if you need it committing. Thanks for finding this. > > Matthew
On Sun, 4 Jun 2017, Matthew Fortune wrote: > > > There are duplicate testcase in gcc.target/mips dir. > > > > > > div-5.c same as div-9.c. > > > div-6.c same as div-10.c. > > > div-7.c same as div-11.c. > > > div-8.c same as div-12.c. > > > > > > Is this deliberate? > > I see no evidence of this being deliberate and has been like this since > the original commit. I suspect they were meant to be `-mgp64' vs `-mgp32' as with the mult-*.c tests also added with r181761 ("Explicitly record which registers are inaccessible") <https://gcc.gnu.org/ml/gcc-patches/2011-10/msg00262.html>, but a typo has crept in. Richard, do you happen to remember anything about it? Maciej
diff --git a/gcc/testsuite/gcc.target/mips/div-10.c b/gcc/testsuite/gcc.target/mips/div-10.c deleted file mode 100644 index fb8953d..0000000 --- a/gcc/testsuite/gcc.target/mips/div-10.c +++ /dev/null @@ -1,12 +0,0 @@ -/* { dg-options "-mgp64 (-mips16)" } */ -/* { dg-final { scan-assembler "\tdivu\t" } } */ -/* { dg-final { scan-assembler "\tmflo\t" } } */ -/* { dg-final { scan-assembler-not "\tmfhi\t" } } */ - -typedef unsigned int SI __attribute__((mode(SI))); - -MIPS16 SI -f (SI x, SI y) -{ - return x / y; -} diff --git a/gcc/testsuite/gcc.target/mips/div-11.c b/gcc/testsuite/gcc.target/mips/div-11.c deleted file mode 100644 index ff12929..0000000 --- a/gcc/testsuite/gcc.target/mips/div-11.c +++ /dev/null @@ -1,12 +0,0 @@ -/* { dg-options "-mgp64 (-mips16)" } */ -/* { dg-final { scan-assembler "\tdiv\t" } } */ -/* { dg-final { scan-assembler-not "\tmflo\t" } } */ -/* { dg-final { scan-assembler "\tmfhi\t" } } */ - -typedef int SI __attribute__((mode(SI))); - -MIPS16 SI -f (SI x, SI y) -{ - return x % y; -} diff --git a/gcc/testsuite/gcc.target/mips/div-12.c b/gcc/testsuite/gcc.target/mips/div-12.c deleted file mode 100644 index 57866ce..0000000 --- a/gcc/testsuite/gcc.target/mips/div-12.c +++ /dev/null @@ -1,12 +0,0 @@ -/* { dg-options "-mgp64 (-mips16)" } */ -/* { dg-final { scan-assembler "\tdivu\t" } } */ -/* { dg-final { scan-assembler-not "\tmflo\t" } } */ -/* { dg-final { scan-assembler "\tmfhi\t" } } */ - -typedef unsigned int SI __attribute__((mode(SI))); - -MIPS16 SI -f (SI x, SI y) -{ - return x % y; -} diff --git a/gcc/testsuite/gcc.target/mips/div-9.c b/gcc/testsuite/gcc.target/mips/div-9.c deleted file mode 100644 index 294cc7f..0000000 --- a/gcc/testsuite/gcc.target/mips/div-9.c +++ /dev/null @@ -1,12 +0,0 @@ -/* { dg-options "-mgp64 (-mips16)" } */ -/* { dg-final { scan-assembler "\tdiv\t" } } */ -/* { dg-final { scan-assembler "\tmflo\t" } } */ -/* { dg-final { scan-assembler-not "\tmfhi\t" } } */ - -typedef int SI __attribute__((mode(SI))); - -MIPS16 SI -f (SI x, SI y) -{ - return x / y; -}
Hi, There are duplicate testcase in gcc.target/mips dir. div-5.c same as div-9.c. div-6.c same as div-10.c. div-7.c same as div-11.c. div-8.c same as div-12.c. Is this deliberate? Otherwise, the attached patch fixing this. Paul. ***ChangeLog*** 2017-06-01 Chenghua Xu <paul.hua.gm@gmail.com> Remove duplicate div-x testcase. * gcc.target/mips/div-9.c: Delete. * gcc.target/mips/div-10.c: Ditto. * gcc.target/mips/div-11.c: Ditto. * gcc.target/mips/div-12.c: Ditto.