| Message ID | 1496266845-11307-1-git-send-email-alexandre.esse.dev@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi Alexandre, On Wed, May 31, 2017 at 11:40 PM, Alexandre Esse <alexandre.esse.dev@gmail.com> wrote: > The daemon service script associated with imx-uuc failed to stop the daemon > since the PID of the process wasn't stored at start time. > > Adding -m option allowed to create the uuc.pid file as expected. > > Signed-off-by: Alexandre Esse <alexandre.esse.dev@gmail.com> Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com> Thanks for your patch. Regards, Gary
Hello, On Wed, 31 May 2017 23:40:45 +0200, Alexandre Esse wrote: > The daemon service script associated with imx-uuc failed to stop the daemon > since the PID of the process wasn't stored at start time. > > Adding -m option allowed to create the uuc.pid file as expected. > > Signed-off-by: Alexandre Esse <alexandre.esse.dev@gmail.com> > --- > package/freescale-imx/imx-uuc/S80imx-uuc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Peter: this should go in the LTS branch. Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > Hello, > On Wed, 31 May 2017 23:40:45 +0200, Alexandre Esse wrote: >> The daemon service script associated with imx-uuc failed to stop the daemon >> since the PID of the process wasn't stored at start time. >> >> Adding -m option allowed to create the uuc.pid file as expected. >> >> Signed-off-by: Alexandre Esse <alexandre.esse.dev@gmail.com> >> --- >> package/freescale-imx/imx-uuc/S80imx-uuc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to master, thanks. Peter: this should go in the LTS branch. Indeed. Committed to 2017.02.x and 2017.05.x, thanks.
diff --git a/package/freescale-imx/imx-uuc/S80imx-uuc b/package/freescale-imx/imx-uuc/S80imx-uuc index 8a02f88..9a92c98 100644 --- a/package/freescale-imx/imx-uuc/S80imx-uuc +++ b/package/freescale-imx/imx-uuc/S80imx-uuc @@ -6,7 +6,7 @@ DAEMON=/usr/bin/$NAME case "$1" in start) printf "Starting $NAME: " - start-stop-daemon -S -q -b -p /var/run/${NAME}.pid -x $DAEMON + start-stop-daemon -S -q -b -m -p /var/run/${NAME}.pid -x $DAEMON [ $? = 0 ] && echo "OK" || echo "FAIL" ;; stop)
The daemon service script associated with imx-uuc failed to stop the daemon since the PID of the process wasn't stored at start time. Adding -m option allowed to create the uuc.pid file as expected. Signed-off-by: Alexandre Esse <alexandre.esse.dev@gmail.com> --- package/freescale-imx/imx-uuc/S80imx-uuc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)