| Message ID | 1496247480-945-3-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Accepted |
| Commit | 2dd2c011e8ab807f8ba1a530fc5f81dffe669ca2 |
| Delegated to: | Simon Glass |
| Headers | show |
On 31 May 2017 at 10:17, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > On the RK3399-Q7, the on-module USB3 hub is held in reset at boot-up > to save power and needs to be woken up using GPIO4A3. > > Note that this is not a negated reset-signal (due to a level shifter > being needed for this signal anyway), but a negated enable-signal: > to enable, we need to output LOW (i.e. 0)... so we mark this as an > ACTIVE_LOW signal. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > arch/arm/dts/rk3399-puma.dts | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On 31 May 2017 at 10:17, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > On the RK3399-Q7, the on-module USB3 hub is held in reset at boot-up > to save power and needs to be woken up using GPIO4A3. > > Note that this is not a negated reset-signal (due to a level shifter > being needed for this signal anyway), but a negated enable-signal: > to enable, we need to output LOW (i.e. 0)... so we mark this as an > ACTIVE_LOW signal. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > arch/arm/dts/rk3399-puma.dts | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-rockchip, thanks!
diff --git a/arch/arm/dts/rk3399-puma.dts b/arch/arm/dts/rk3399-puma.dts index 5d9dfb5..7009fde 100644 --- a/arch/arm/dts/rk3399-puma.dts +++ b/arch/arm/dts/rk3399-puma.dts @@ -124,7 +124,7 @@ }; &dwc3_typec0 { - status = "okay"; + status = "disabled"; }; &usb_host1_ehci { @@ -136,6 +136,7 @@ }; &dwc3_typec1 { + rockchip,vbus-gpio = <&gpio4 3 GPIO_ACTIVE_LOW>; status = "okay"; }; @@ -182,7 +183,7 @@ compatible = "spi-flash"; reg = <0>; - spi-max-frequency = <5000000>; + spi-max-frequency = <49500000>; spi-cpol; spi-cpha; };
On the RK3399-Q7, the on-module USB3 hub is held in reset at boot-up to save power and needs to be woken up using GPIO4A3. Note that this is not a negated reset-signal (due to a level shifter being needed for this signal anyway), but a negated enable-signal: to enable, we need to output LOW (i.e. 0)... so we mark this as an ACTIVE_LOW signal. Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> --- arch/arm/dts/rk3399-puma.dts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)