diff mbox

[U-Boot,5/6] rockchip: defconfig: puma-rk3399: do not filter clock-names for SPL

Message ID 1496247531-1221-5-git-send-email-philipp.tomsich@theobroma-systems.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Philipp Tomsich May 31, 2017, 4:18 p.m. UTC
For the RK3399-Q7 module, we use full OF_CONTROL (i.e. not
OF_PLATDATA) for SPL.  In this configuration, the rockchip_dw_mmc
driver retrieves one of its clocks via clk_get_by_name and fails if
this is not possible.  For this reason, we can not filter clock-names
from the device-tree nodes used for the configuration of the SPL
stage.

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---

Changes in v2: None

 configs/puma-rk3399_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass June 2, 2017, 2:55 a.m. UTC | #1
On 31 May 2017 at 10:18, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> For the RK3399-Q7 module, we use full OF_CONTROL (i.e. not
> OF_PLATDATA) for SPL.  In this configuration, the rockchip_dw_mmc
> driver retrieves one of its clocks via clk_get_by_name and fails if
> this is not possible.  For this reason, we can not filter clock-names
> from the device-tree nodes used for the configuration of the SPL
> stage.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
> Changes in v2: None
>
>  configs/puma-rk3399_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Simon Glass June 5, 2017, 9:31 p.m. UTC | #2
On 31 May 2017 at 10:18, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> For the RK3399-Q7 module, we use full OF_CONTROL (i.e. not
> OF_PLATDATA) for SPL.  In this configuration, the rockchip_dw_mmc
> driver retrieves one of its clocks via clk_get_by_name and fails if
> this is not possible.  For this reason, we can not filter clock-names
> from the device-tree nodes used for the configuration of the SPL
> stage.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
> Changes in v2: None
>
>  configs/puma-rk3399_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-rockchip, thanks!
diff mbox

Patch

diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig
index 413d0ac..ab49f27 100644
--- a/configs/puma-rk3399_defconfig
+++ b/configs/puma-rk3399_defconfig
@@ -36,7 +36,7 @@  CONFIG_CMD_TIME=y
 CONFIG_CMD_PMIC=y
 CONFIG_CMD_REGULATOR=y
 CONFIG_SPL_OF_CONTROL=y
-CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
+CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
 CONFIG_REGMAP=y
 CONFIG_SPL_REGMAP=y
 CONFIG_SYSCON=y