diff mbox

[v2,43/45] tests/qdict: check more get_try_int() cases

Message ID 20170531135709.345-44-marcandre.lureau@redhat.com
State New
Headers show

Commit Message

Marc-André Lureau May 31, 2017, 1:57 p.m. UTC 
Suggested by Markus Armbruster.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/check-qdict.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Markus Armbruster June 6, 2017, 12:26 p.m. UTC | #1 
Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Suggested by Markus Armbruster.

Prefer

  Suggested-by: Markus Armbruster <armbru@redhat.com>

> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff mbox

Patch

diff --git a/tests/check-qdict.c b/tests/check-qdict.c
index 5c70490e83..889b43b57d 100644
--- a/tests/check-qdict.c
+++ b/tests/check-qdict.c
@@ -117,10 +117,17 @@  static void qdict_get_try_int_test(void)
     QDict *tests_dict = qdict_new();
 
     qdict_put_int(tests_dict, key, value);
+    qdict_put_str(tests_dict, "string", "test");
 
     ret = qdict_get_try_int(tests_dict, key, 0);
     g_assert(ret == value);
 
+    ret = qdict_get_try_int(tests_dict, "missing", -42);
+    g_assert_cmpuint(ret, ==, -42);
+
+    ret = qdict_get_try_int(tests_dict, "string", -42);
+    g_assert_cmpuint(ret, ==, -42);
+
     QDECREF(tests_dict);
 }