| Message ID | 20170531135709.345-32-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
Marc-André Lureau <marcandre.lureau@redhat.com> writes: > Those properties use visit_type_uint*() > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > hw/i386/acpi-build.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 8ae0373541..64a277b974 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -247,19 +247,19 @@ static void acpi_get_pci_holes(Range *hole, Range *hole64) > g_assert(pci_host); > > range_set_bounds1(hole, > - object_property_get_int(pci_host, > - PCI_HOST_PROP_PCI_HOLE_START, > - NULL), > - object_property_get_int(pci_host, > - PCI_HOST_PROP_PCI_HOLE_END, > - NULL)); > + object_property_get_uint(pci_host, > + PCI_HOST_PROP_PCI_HOLE_START, > + NULL), > + object_property_get_uint(pci_host, > + PCI_HOST_PROP_PCI_HOLE_END, > + NULL)); > range_set_bounds1(hole64, > - object_property_get_int(pci_host, > - PCI_HOST_PROP_PCI_HOLE64_START, > - NULL), > - object_property_get_int(pci_host, > - PCI_HOST_PROP_PCI_HOLE64_END, > - NULL)); > + object_property_get_uint(pci_host, > + PCI_HOST_PROP_PCI_HOLE64_START, > + NULL), > + object_property_get_uint(pci_host, > + PCI_HOST_PROP_PCI_HOLE64_END, > + NULL)); > } > > #define ACPI_PORT_SMI_CMD 0x00b2 /* TODO: this is APM_CNT_IOPORT */ Related to the hw/pci-host/ part of PATCH 17. Reshuffling stuff to ease review is almost certainly not worth the trouble. I like how PATCH 22-42 justify each change in the commit message.
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 8ae0373541..64a277b974 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -247,19 +247,19 @@ static void acpi_get_pci_holes(Range *hole, Range *hole64) g_assert(pci_host); range_set_bounds1(hole, - object_property_get_int(pci_host, - PCI_HOST_PROP_PCI_HOLE_START, - NULL), - object_property_get_int(pci_host, - PCI_HOST_PROP_PCI_HOLE_END, - NULL)); + object_property_get_uint(pci_host, + PCI_HOST_PROP_PCI_HOLE_START, + NULL), + object_property_get_uint(pci_host, + PCI_HOST_PROP_PCI_HOLE_END, + NULL)); range_set_bounds1(hole64, - object_property_get_int(pci_host, - PCI_HOST_PROP_PCI_HOLE64_START, - NULL), - object_property_get_int(pci_host, - PCI_HOST_PROP_PCI_HOLE64_END, - NULL)); + object_property_get_uint(pci_host, + PCI_HOST_PROP_PCI_HOLE64_START, + NULL), + object_property_get_uint(pci_host, + PCI_HOST_PROP_PCI_HOLE64_END, + NULL)); } #define ACPI_PORT_SMI_CMD 0x00b2 /* TODO: this is APM_CNT_IOPORT */
Those properties use visit_type_uint*() Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- hw/i386/acpi-build.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)