diff mbox

[U-Boot,v2,08/10] patman: Add a maintainer test feature to MakeCcFile()

Message ID 20170529213132.21217-9-sjg@chromium.org
State Accepted
Commit 1f487f85d2d2a78a8d4e533253ed5c853540aea1
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass May 29, 2017, 9:31 p.m. UTC 
Allow the add_maintainers parameter to be a list of maintainers, thus
allowing us to simulate calling the script in tests without actually
needing it to work.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v2: None

 tools/patman/series.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Simon Glass June 7, 2017, 1:47 a.m. UTC | #1 
Allow the add_maintainers parameter to be a list of maintainers, thus
allowing us to simulate calling the script in tests without actually
needing it to work.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v2: None

 tools/patman/series.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Applied to u-boot-dm, thanks!
diff mbox

Patch

diff --git a/tools/patman/series.py b/tools/patman/series.py
index 7a3534fee9..395b9ea99b 100644
--- a/tools/patman/series.py
+++ b/tools/patman/series.py
@@ -212,7 +212,9 @@  class Series(dict):
             cover_fname: If non-None the name of the cover letter.
             raise_on_error: True to raise an error when an alias fails to match,
                 False to just print a message.
-            add_maintainers: Call the get_maintainers to CC maintainers
+            add_maintainers: Either:
+                True/False to call the get_maintainers to CC maintainers
+                List of maintainers to include (for testing)
         Return:
             Filename of temp file created
         """
@@ -227,7 +229,9 @@  class Series(dict):
                                                raise_on_error=raise_on_error)
             list += gitutil.BuildEmailList(commit.cc_list,
                                            raise_on_error=raise_on_error)
-            if add_maintainers:
+            if type(add_maintainers) == type(list):
+                list += add_maintainers
+            elif add_maintainers:
                 list += get_maintainer.GetMaintainer(commit.patch)
             list = [m.encode('utf-8') if type(m) != str else m for m in list]
             all_ccs += list