diff mbox

[U-Boot,v2,06/10] patman: Don't return the series in FixPatches()

Message ID 20170529213132.21217-7-sjg@chromium.org
State Accepted
Commit db116cc8d095ec499ae748ea864fa0def54ca3d6
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass May 29, 2017, 9:31 p.m. UTC
There is no need for this function to return the same object that was
passed in. Drop the return value.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v2: None

 tools/patman/patchstream.py | 1 -
 tools/patman/patman.py      | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

Simon Glass June 7, 2017, 1:47 a.m. UTC | #1
There is no need for this function to return the same object that was
passed in. Drop the return value.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v2: None

 tools/patman/patchstream.py | 1 -
 tools/patman/patman.py      | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

Applied to u-boot-dm, thanks!
diff mbox

Patch

diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index 324c65442f..6098728aa1 100644
--- a/tools/patman/patchstream.py
+++ b/tools/patman/patchstream.py
@@ -477,7 +477,6 @@  def FixPatches(series, fnames):
             print
         count += 1
     print('Cleaned %d patches' % count)
-    return series
 
 def InsertCoverLetter(fname, series, count):
     """Inserts a cover letter with the required info into patch 0
diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index fdbee67f55..63da3f3200 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -141,8 +141,8 @@  else:
                 series)
 
     # Fix up the patch files to our liking, and insert the cover letter
-    series = patchstream.FixPatches(series, args)
-    if series and cover_fname and series.get('cover'):
+    patchstream.FixPatches(series, args)
+    if cover_fname and series.get('cover'):
         patchstream.InsertCoverLetter(cover_fname, series, options.count)
 
     # Do a few checks on the series