Message ID | 1495972813-13475-11-git-send-email-roid@mellanox.com |
---|---|
State | Superseded |
Headers | show |
On Sun, May 28, 2017 at 02:59:52PM +0300, Roi Dayan wrote: > From: Paul Blakey <paulb@mellanox.com> > > Signed-off-by: Paul Blakey <paulb@mellanox.com> > Reviewed-by: Roi Dayan <roid@mellanox.com> > Reviewed-by: Simon Horman <simon.horman@netronome.com> > --- > lib/netdev-tc-offloads.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) Thanks, this looks good to me. I would be happy to apply it if someone provided a review. I am taking a pause in looking over the patches now - I have looked over 1 - 10 and they seem good to me. I applied 03/31 which has been reviewed. And I will look out for reviews (by others) of those patches which have not been reviewed with a view to applying more patches. Please feel free to post v10 whenever you feel it is appropriate.
On Sun, May 28, 2017 at 02:59:52PM +0300, Roi Dayan wrote: > From: Paul Blakey <paulb@mellanox.com> > > Signed-off-by: Paul Blakey <paulb@mellanox.com> > Reviewed-by: Roi Dayan <roid@mellanox.com> > Reviewed-by: Simon Horman <simon.horman@netronome.com> > --- Acked-by: Flavio Leitner <fbl@sysclose.org>
diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 46017d8..e766972 100644 --- a/lib/netdev-tc-offloads.c +++ b/lib/netdev-tc-offloads.c @@ -36,10 +36,20 @@ VLOG_DEFINE_THIS_MODULE(netdev_tc_offloads); +static struct vlog_rate_limit error_rl = VLOG_RATE_LIMIT_INIT(60, 5); + int -netdev_tc_flow_flush(struct netdev *netdev OVS_UNUSED) +netdev_tc_flow_flush(struct netdev *netdev) { - return EOPNOTSUPP; + int ifindex = netdev_get_ifindex(netdev); + + if (ifindex < 0) { + VLOG_ERR_RL(&error_rl, "failed to get ifindex for %s: %s", + netdev_get_name(netdev), ovs_strerror(-ifindex)); + return -ifindex; + } + + return tc_flush(ifindex); } int