| Message ID | 20170526231733.10745-1-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
Acked-By: Miguel Angel Ajo <majopela@redhat.com> On Sat, May 27, 2017 at 1:17 AM, Ben Pfaff <blp@ovn.org> wrote: > Found by Coverity. > > Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/ > fileInstanceId=14763066&defectInstanceId=4305324&mergedDefectId=180404& > fileStart=251&fileEnd=500 > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > ovn/controller/ovn-controller.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn- > controller.c > index f22551d6dcf3..1ff1b5b738a9 100644 > --- a/ovn/controller/ovn-controller.c > +++ b/ovn/controller/ovn-controller.c > @@ -238,6 +238,7 @@ create_br_int(struct controller_ctx *ctx, > bridges[cfg->n_bridges] = bridge; > ovsrec_open_vswitch_verify_bridges(cfg); > ovsrec_open_vswitch_set_bridges(cfg, bridges, cfg->n_bridges + 1); > + free(bridges); > > return bridge; > } > -- > 2.10.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
Thank you! I applied this to master, branch-2.7, and branch-2.6. On Mon, May 29, 2017 at 01:34:29PM +0200, Miguel Angel Ajo Pelayo wrote: > Acked-By: Miguel Angel Ajo <majopela@redhat.com> > > On Sat, May 27, 2017 at 1:17 AM, Ben Pfaff <blp@ovn.org> wrote: > > > Found by Coverity. > > > > Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/ > > fileInstanceId=14763066&defectInstanceId=4305324&mergedDefectId=180404& > > fileStart=251&fileEnd=500 > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > ovn/controller/ovn-controller.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn- > > controller.c > > index f22551d6dcf3..1ff1b5b738a9 100644 > > --- a/ovn/controller/ovn-controller.c > > +++ b/ovn/controller/ovn-controller.c > > @@ -238,6 +238,7 @@ create_br_int(struct controller_ctx *ctx, > > bridges[cfg->n_bridges] = bridge; > > ovsrec_open_vswitch_verify_bridges(cfg); > > ovsrec_open_vswitch_set_bridges(cfg, bridges, cfg->n_bridges + 1); > > + free(bridges); > > > > return bridge; > > } > > -- > > 2.10.2 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >
diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index f22551d6dcf3..1ff1b5b738a9 100644 --- a/ovn/controller/ovn-controller.c +++ b/ovn/controller/ovn-controller.c @@ -238,6 +238,7 @@ create_br_int(struct controller_ctx *ctx, bridges[cfg->n_bridges] = bridge; ovsrec_open_vswitch_verify_bridges(cfg); ovsrec_open_vswitch_set_bridges(cfg, bridges, cfg->n_bridges + 1); + free(bridges); return bridge; }
Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763066&defectInstanceId=4305324&mergedDefectId=180404&fileStart=251&fileEnd=500 Signed-off-by: Ben Pfaff <blp@ovn.org> --- ovn/controller/ovn-controller.c | 1 + 1 file changed, 1 insertion(+)