diff mbox

[v3,2/3] qemu.py: Add QEMUMachine.exitcode() method

Message ID 20170526181200.17227-3-ehabkost@redhat.com
State New
Headers show

Commit Message

Eduardo Habkost May 26, 2017, 6:11 p.m. UTC
Allow the exit code of QEMU to be queried by scripts.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 scripts/qemu.py | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Markus Armbruster May 29, 2017, 4:53 p.m. UTC | #1
Eduardo Habkost <ehabkost@redhat.com> writes:

> Allow the exit code of QEMU to be queried by scripts.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  scripts/qemu.py | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 16934f1e02..ebe1c4b919 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -88,6 +88,10 @@ class QEMUMachine(object):
>      def is_running(self):
>          return self._popen and (self._popen.returncode is None)
>  
> +    def exitcode(self):
> +        if self._popen:
> +            return self._popen.returncode
> +

Falling off the function's end returns None.  Do we really want to rely
on that?

For what it's worth, I checked the Python Language Reference, found it
less than clear, so I tried it out, too.

>      def get_pid(self):
>          if not self.is_running():
>              return None
diff mbox

Patch

diff --git a/scripts/qemu.py b/scripts/qemu.py
index 16934f1e02..ebe1c4b919 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -88,6 +88,10 @@  class QEMUMachine(object):
     def is_running(self):
         return self._popen and (self._popen.returncode is None)
 
+    def exitcode(self):
+        if self._popen:
+            return self._popen.returncode
+
     def get_pid(self):
         if not self.is_running():
             return None