From patchwork Sun Dec 26 22:50:31 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Pero X-Patchwork-Id: 76726 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 1870EB70E2 for ; Mon, 27 Dec 2010 09:50:47 +1100 (EST) Received: (qmail 19311 invoked by alias); 26 Dec 2010 22:50:44 -0000 Received: (qmail 19293 invoked by uid 22791); 26 Dec 2010 22:50:42 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, TW_BJ X-Spam-Check-By: sourceware.org Received: from smtp181.iad.emailsrvr.com (HELO smtp181.iad.emailsrvr.com) (207.97.245.181) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 26 Dec 2010 22:50:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp38.relay.iad1a.emailsrvr.com (SMTP Server) with ESMTP id 60E183481BA; Sun, 26 Dec 2010 17:50:34 -0500 (EST) Received: by smtp38.relay.iad1a.emailsrvr.com (Authenticated sender: nicola.pero-AT-meta-innovation.com) with ESMTPA id 6E20E348210; Sun, 26 Dec 2010 17:50:33 -0500 (EST) Cc: gcc-patches@gcc.gnu.org, IainS@gcc.gnu.org Message-Id: From: Nicola Pero To: dominiq@lps.ens.fr (Dominique Dhumieres) In-Reply-To: <20101226220514.648AC3BE18@mailhost.lps.ens.fr> Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: libobjc: run testcases with Apple runtime as well Date: Sun, 26 Dec 2010 23:50:31 +0100 References: <20101226220514.648AC3BE18@mailhost.lps.ens.fr> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Dominique thanks for the quick feedback :-) Apologies for the failures - I did test on an Apple m32 but forgot to disable the tests on m64 (we still can't compile Objective-C for m64 on Apple yet, as it requires outputting code for the new ABI which we haven't implemented yet). ;-) I disabled them in that case. Can you try updating from subversion and running the tests again and confirming it all looks good now ? Thanks PS: Here is the (trivial) change that I applied to disable them on m64 --- /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: ChangeLog =================================================================== --- ChangeLog (revision 168255) +++ ChangeLog (working copy) @@ -1,5 +1,24 @@ 2010-12-26 Nicola Pero + * objc.dg/gnu-api-2-class.m: Xfail the test on Apple Darwin m64. + * objc.dg/gnu-api-2-ivar.m: Same. + * objc.dg/gnu-api-2-method.m: Same. + * objc.dg/gnu-api-2-objc.m: Same. + * objc.dg/gnu-api-2-object.m: Same. + * objc.dg/gnu-api-2-protocol.m: Same. + * obj-c++.dg/gnu-api-2-class.mm: Same. + * obj-c++.dg/gnu-api-2-ivar.mm: Same. + * obj-c++.dg/gnu-api-2-method.mm: Same. + * obj-c++.dg/gnu-api-2-objc.mm: Same. + * obj-c++.dg/gnu-api-2-object.mm: Same. + * obj-c++.dg/gnu-api-2-protocol.mm: Same. + +2010-12-26 Nicola Pero + * objc.dg/pr44509.m: New. 2010-12-26 Nicola Pero Index: objc.dg/gnu-api-2-ivar.m =================================================================== --- objc.dg/gnu-api-2-ivar.m (revision 168255) +++ objc.dg/gnu-api-2-ivar.m (working copy) @@ -3,6 +3,7 @@ This is test 'ivar', covering all functions starting with 'ivar'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: objc.dg/gnu-api-2-object.m =================================================================== --- objc.dg/gnu-api-2-object.m (revision 168255) +++ objc.dg/gnu-api-2-object.m (working copy) @@ -3,6 +3,7 @@ This is test 'object', covering all functions starting with 'object'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: objc.dg/gnu-api-2-objc.m =================================================================== --- objc.dg/gnu-api-2-objc.m (revision 168255) +++ objc.dg/gnu-api-2-objc.m (working copy) @@ -3,6 +3,7 @@ This is test 'objc', covering all functions starting with 'objc'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: objc.dg/gnu-api-2-protocol.m =================================================================== --- objc.dg/gnu-api-2-protocol.m (revision 168255) +++ objc.dg/gnu-api-2-protocol.m (working copy) @@ -3,6 +3,7 @@ This is test 'protocol', covering all functions starting with 'protocol'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: objc.dg/gnu-api-2-class.m =================================================================== --- objc.dg/gnu-api-2-class.m (revision 168255) +++ objc.dg/gnu-api-2-class.m (working copy) @@ -3,6 +3,7 @@ This is test 'class', covering all functions starting with 'class'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: objc.dg/gnu-api-2-method.m =================================================================== --- objc.dg/gnu-api-2-method.m (revision 168255) +++ objc.dg/gnu-api-2-method.m (working copy) @@ -3,6 +3,7 @@ This is test 'method', covering all functions starting with 'method'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: obj-c++.dg/gnu-api-2-protocol.mm =================================================================== --- obj-c++.dg/gnu-api-2-protocol.mm (revision 168255) +++ obj-c++.dg/gnu-api-2-protocol.mm (working copy) @@ -3,6 +3,7 @@ This is test 'protocol', covering all functions starting with 'protocol'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: obj-c++.dg/gnu-api-2-object.mm =================================================================== --- obj-c++.dg/gnu-api-2-object.mm (revision 168255) +++ obj-c++.dg/gnu-api-2-object.mm (working copy) @@ -3,6 +3,7 @@ This is test 'object', covering all functions starting with 'object'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: obj-c++.dg/gnu-api-2-method.mm =================================================================== --- obj-c++.dg/gnu-api-2-method.mm (revision 168255) +++ obj-c++.dg/gnu-api-2-method.mm (working copy) @@ -3,6 +3,7 @@ This is test 'method', covering all functions starting with 'method'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: obj-c++.dg/gnu-api-2-objc.mm =================================================================== --- obj-c++.dg/gnu-api-2-objc.mm (revision 168255) +++ obj-c++.dg/gnu-api-2-objc.mm (working copy) @@ -3,6 +3,7 @@ This is test 'objc', covering all functions starting with 'objc'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: obj-c++.dg/gnu-api-2-ivar.mm =================================================================== --- obj-c++.dg/gnu-api-2-ivar.mm (revision 168255) +++ obj-c++.dg/gnu-api-2-ivar.mm (working copy) @@ -3,6 +3,7 @@ This is test 'ivar', covering all functions starting with 'ivar'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* To get the modern GNU Objective-C Runtime API, you include objc/runtime.h. */ Index: obj-c++.dg/gnu-api-2-class.mm =================================================================== --- obj-c++.dg/gnu-api-2-class.mm (revision 168255) +++ obj-c++.dg/gnu-api-2-class.mm (working copy) @@ -3,6 +3,7 @@ This is test 'class', covering all functions starting with 'class'. */ /* { dg-do run } */ +/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */